feat(faseC): native deltix pull + fetch (fast-forward) over REST NDJSON - #17
Merged
Conversation
Replaces the file-based gRPC pull with a commit-based native pull, mirroring git. Adds fetch as its own command. Client: - VersioningApiAdapter: fetchRefs (GET /refs), pullCommits (GET /pull-commits, parses NDJSON + X-Deltix-Server-Head). ImportedTable now carries schema DDL. - VersioningService: fetchRefs / pullCommits wrappers. - VersioningLocalService: applyCommits (create table from DDL or truncate, reload rows, commit with original msg/author), getRemoteHead, checkout; getUnpushedCommits now exports schema DDL per table too. - CLI: deltix pull = fast-forward (download commits since origin/<branch>, apply onto local branch, advance origin); deltix fetch materializes onto origin/<branch> without touching the working branch. Divergence (local ahead) is refused with a clear message (merge is Fase D). Retires the legacy 'deltix pull <repo> <file>' gRPC path (dataflow import removed from CLI). Verified against real Dolt: applyCommits of server-shaped commits into a fresh repo -> data, primary key, per-commit authors and origin/<branch> pointer all correct. 111 unit tests pass, build + lint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the file-based gRPC pull with a commit-based native
deltix pull(git-like), and addsdeltix fetch. Depends on the server export endpoints (Fase B) and the schema-DDL import fix.Changes
fetchRefs(GET /refs),pullCommits(GET /pull-commits → NDJSON +X-Deltix-Server-Head).ImportedTablenow carries schema DDL.fetchRefs/pullCommitswrappers.applyCommits(create table from DDL or truncate + reload rows + commit with original msg/author),getRemoteHead,checkout;getUnpushedCommitsnow exports schema DDL per table.deltix pull= fast-forward (download commits sinceorigin/<branch>, apply onto local branch, advance origin).deltix fetchmaterializes ontoorigin/<branch>without touching the working branch. Divergence (local ahead) is refused with a clear message — merge is Fase D. Retires the legacydeltix pull <repo> <file>gRPC path.Verification
Real Dolt:
applyCommitsof server-shaped commits into a fresh repo → data, primary key, per-commit authors andorigin/<branch>pointer all correct. 111 unit tests pass, build + lint clean.Note
pullcommand signature changed (no file arg) — breaking for the old file-pull. CHANGELOG/version bump handled at the end of the roadmap.