Skip to content

MatrixArray構造体を実装し、行列の生成と要素取得メソッドを追加#41

Closed
SanaeProject wants to merge 9 commits into
rustfrom
def/matrix_array
Closed

MatrixArray構造体を実装し、行列の生成と要素取得メソッドを追加#41
SanaeProject wants to merge 9 commits into
rustfrom
def/matrix_array

Conversation

@SanaeProject
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 30, 2026 15:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an initial Rust crate for matrix functionality alongside the existing C++ NeuralNetwork codebase, introducing a MatrixArray type and exposing it from the Rust library.

Changes:

  • Added a Rust MatrixArray implementation with size/data constructors and element access.
  • Added Rust crate metadata and lockfile.
  • Added generated Cargo/rust-analyzer build artifacts under rust/target.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
rust/src/matrix_array.rs Adds the MatrixArray struct, constructors, and get accessors for row/column-major layouts.
rust/src/lib.rs Exposes the new matrix module.
rust/Cargo.toml Defines the new Rust package.
rust/Cargo.lock Records the generated Cargo lock data.
rust/target/CACHEDIR.TAG Adds generated Cargo cache metadata.
rust/target/.rustc_info.json Adds generated rustc/toolchain metadata.
rust/target/flycheck0/stdout Adds generated rust-analyzer flycheck output.
rust/target/flycheck0/stderr Adds generated cargo stderr output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rust/src/matrix_array.rs Outdated
Comment thread rust/src/matrix_array.rs Outdated
Comment thread rust/src/matrix_array.rs Outdated
Comment thread rust/src/matrix_array.rs Outdated
Comment thread rust/target/CACHEDIR.TAG Outdated
Copilot AI review requested due to automatic review settings May 31, 2026 04:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Comment thread rust/target/flycheck0/stdout Outdated
Comment thread rust/target/flycheck0/stderr Outdated
Comment thread rust/target/.rustc_info.json Outdated
Comment thread rust/target/CACHEDIR.TAG Outdated
@SanaeProject SanaeProject marked this pull request as ready for review May 31, 2026 07:01
Copilot AI review requested due to automatic review settings May 31, 2026 07:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 11 comments.

Comment thread rust/target/CACHEDIR.TAG Outdated
Comment thread rust/target/.rustc_info.json Outdated
Comment thread rust/target/flycheck0/stdout Outdated
Comment thread rust/target/flycheck0/stderr Outdated
Comment thread rust/src/matrix.rs
Comment thread rust/src/matrix.rs Outdated
Comment thread rust/src/matrix.rs
Comment thread rust/src/matrix_layout.rs Outdated
Comment thread rust/src/matrix_layout.rs Outdated
Comment thread rust/src/main.rs
Copilot AI review requested due to automatic review settings May 31, 2026 07:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Comment thread rust/src/matrix.rs
Comment thread rust/src/matrix.rs Outdated
Comment thread rust/src/matrix.rs Outdated
Comment thread rust/src/matrix.rs
Comment thread rust/src/matrix.rs
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Comment thread rust/src/matrix.rs
Comment thread rust/src/matrix.rs Outdated
Comment thread rust/src/matrix.rs Outdated
Comment thread rust/src/matrix.rs
Comment thread rust/src/main.rs
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Comment thread rust/src/matrix.rs
Comment thread rust/src/matrix.rs
Comment thread rust/src/main.rs
@SanaeProject SanaeProject deleted the def/matrix_array branch June 1, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants