Fix doctest failure in find_identifiable_functions - #546
Merged
ChrisRackauckas merged 1 commit intoAug 26, 2026
Conversation
AbstractAlgebra/Nemo now print multivariate terms in a different variable order, so the expected doctest output (`a12 + a01 + a21`) no longer matches the actual output (`a01 + a12 + a21`). Also add the `Logging.disable_logging(Logging.Info)` doctest setup that every other doctest in this file's neighbors already uses, since the `@info` messages emitted by `find_identifiable_functions` were being captured by Documenter and were never part of the expected `# output` block, causing the doctest to fail independently of the term ordering. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing Documentation workflow (doctest failure in
src/identifiable_functions.jl:33-49).Root cause: two independent issues in the
find_identifiable_functionsdoctest:a12 + a01 + a21/a12*a01, but the currently pinned AbstractAlgebra/Nemo now print multivariate terms in a different (lexicographic-by-name) variable order, producinga01 + a12 + a21/a01*a12.Logging.disable_logging(Logging.Info)setup that every neighboring doctest in this file's sibling files (util.jl,parametrizations.jl,input_macro.jl) already uses.find_identifiable_functionsemits@infoprogress messages by default, which Documenter's doctest runner captures as part of the evaluated output. Since the# outputblock never included those log lines, the doctest would fail on this basis alone, independent of the term-ordering issue above.Fix
# outputblock to match the current term ordering.; setup = :(using Logging; Logging.disable_logging(Logging.Info);)to the```jldoctestfence, matching the established convention elsewhere in the codebase.Test plan
julia --project=docs -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'followed byjulia --project=docs docs/make.jllocally against this branch — the fullmakedocsbuild (including all doctests) completes successfully with no doctest errors.Made with Cursor