Skip to content

ci: enable delete_missing_settings in deploy workflows#13

Merged
nicomiguelino merged 1 commit intomainfrom
feat/add-delete-missing-settings
Apr 27, 2026
Merged

ci: enable delete_missing_settings in deploy workflows#13
nicomiguelino merged 1 commit intomainfrom
feat/add-delete-missing-settings

Conversation

@nicomiguelino
Copy link
Copy Markdown
Contributor

Enable delete_missing_settings across all deploy workflows to remove stale settings from the server that are no longer present in the manifest.

Changes

  • Pass delete_missing_settings: 'true' to both jobs in update-edge-app.yml
  • Add --delete-missing-settings=true to the edge-app deploy call in update-rss-reader-apps.yml

- Add `delete_missing_settings: 'true'` to both jobs in update-edge-app.yml
- Add `--delete-missing-settings=true` to edge-app deploy in update-rss-reader-apps.yml
@nicomiguelino nicomiguelino self-assigned this Apr 24, 2026
@nicomiguelino nicomiguelino marked this pull request as ready for review April 24, 2026 22:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables “delete missing settings” behavior in deploy workflows so stale server-side settings get removed when they’re no longer present in the app manifest.

Changes:

  • Add --delete-missing-settings=true to the edge-app deploy command in the RSS reader update workflow.
  • Pass delete_missing_settings: 'true' to both stage and production jobs in the Edge App update workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/update-rss-reader-apps.yml Adds --delete-missing-settings=true to the deploy command for matrix app updates.
.github/workflows/update-edge-app.yml Enables delete_missing_settings input for both stage and production update jobs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/update-rss-reader-apps.yml
@nicomiguelino nicomiguelino merged commit 0a6b3d0 into main Apr 27, 2026
5 checks passed
@nicomiguelino nicomiguelino deleted the feat/add-delete-missing-settings branch April 27, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants