Consistent clearing of deduced data#253
Merged
Merged
Conversation
this must be done _before_ the properties_dict is generated, otherwise each second deduce run only deduces 0 properties.
ScriptRaccoon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make each run of the deduction script independent, all deduced information must be cleared first. This was already done for deduced proofs of properties and implications. However, for deduced proofs of properties, the clearing was performed (probably after some recent refactoring) only after the property dictionary was generated, which was too late. As a result, every second run of the script deduced 0 properties, since all entries were already present. This has now been fixed.
Additionally, there was no such clearing for deduced special objects and special morphisms associated with categories. To address this, this PR adds a new column
is_deducedto both tables. During the deduction of special objects and morphisms in dual categories, the deduced entries are cleared first, and newly generated entries are marked as deduced.Moreover, the restriction of representable functors to functors with codomain Set has been moved to the end of the deduction script, and these assignments are now also marked as deduced. This also ensures that each run produces the same output.