🎨 Palette: Progressive character limit feedback - #162
Conversation
Added progressive visual feedback to the character counter in the ResponseForm. The counter text changes to orange when approaching the limit (>=240 characters) and red when reaching the limit (300 characters). Added visually hidden `role="status"` elements to announce when the user is approaching or has reached the character limit for screen readers without causing noisy updates on every keystroke. Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d059796ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {alternativeThought.length >= 240 && alternativeThought.length < 300 && ( | ||
| <div role="status" className="sr-only">Approaching character limit</div> | ||
| )} | ||
| {alternativeThought.length >= 300 && ( | ||
| <div role="status" className="sr-only">Character limit reached</div> |
There was a problem hiding this comment.
For screen-reader users relying on these new threshold announcements, the role="status" nodes are created only after they already contain the message, which many assistive-technology/browser combinations do not announce for polite live regions; role="status" is meant to expose changes to an existing live region. This makes the 80% and 100% warnings unreliable even though the visible color change works, so render a stable sr-only status element up front and update its text when the threshold changes.
Useful? React with 👍 / 👎.
1 participant
💡 What:
Added progressive visual feedback to the character counter in the ResponseForm and improved its screen reader experience. The counter changes to orange and bold when approaching the limit, and red and bold when reached.
🎯 Why:
Input fields with character limits need clear, progressive feedback. However, using
aria-livedirectly on the changing numbers creates extremely noisy and confusing updates for screen reader users.📸 Before/After:
(Visual changes verified locally via playwright screenshots. The counter was previously always gray.)
♿ Accessibility:
aria-hidden="true".role="status"andclassName="sr-only"when crossing critical thresholds (80% and 100%), ensuring polite and helpful announcements without keystroke spam.PR created automatically by Jules for task 9032462378034934457 started by @Sczitzo