Conversation
Sean-Der
force-pushed
the
ice-tcp
branch
2 times, most recently
from
November 22, 2025 12:30
4b3372b to
5dee083
Compare
This aligns obs_canvas_get_video_info() and obs_get_video_info() and ensures the frame-rate is correct rather than returning the potentially stale data stored in the canvas itself.
The NVENC session was destroyed before its child resources (textures, surfaces) were cleaned up, causing resource cleanup calls to operate on an invalid session handle. Reorder destruction to free all registered resources before destroying the encoder session.
These modifiers cannot be used with the standard texture sampling codepaths, so we need to reject them to avoid invalid GL operations. Closes obsproject#12498
Previously, the Image Slide Show source skipped *.webp files when adding images via 'Add Directory'. This update ensures that .webp files are now correctly included.
CreateFileW returns INVALID_HANDLE_VALUE on failure, not NULL. The previous check would always evaluate to true on failure, causing ReadFile and CloseHandle to be called on an invalid handle.
Replaced implicit type conversion within macOS plugins (mac-capture, mac-syphon, mac-videotoolbox, mac-virtualcam) with explicit type conversions to clear compile errors with Apple Clang 21.0 and Xcode 26.4. Co-authored-by: PatTheMav <patthemav+github@gmail.com> Co-authored-by: jcm <6864788+jcm93@users.noreply.github.com>
Also, change from actions/attest-build-provenance to actions/attest. The former is just a wrapper around the latter now.
Update to remove node20 deprecation warnings. Also update the source of the action since the name has changed.
Update to remove node20 deprecation warnings. Also update the source of the action since the name has changed.
Update both flatpak-builder and flat-manager.
Update both the download and upload actions.
CI: Update GitHub actions
Provide ability to use power of 2.4 to simulate BT.1886 for Rec. 709.
Previously, if download failure occurred or interrupted by Ctrl-C, the broken file is not removed. This is true for the first case because "message(FATAL_ERROR ..." stops cmake and "file(REMOVE ..." is never reached. After that, if cmake is run second time, SHA256 verification is skipped and the broken file will be used. This patch fixes this by using a temporary intermediate file. The file data is downloaded into a temporary file first, then the temporary file is atomically renamed to destination. Error checking of download status is also improved. The if clause now checks error code against zero more strictly, according to cmake's documentation.
The updates config folder is used to download files tied to update branch selection and application updates. If this folder does not exist, the downloads fail. Tying this folder creation to What's New, which also uses this folder, seems incorrect, since it is also uses for application updates. Remove the ifdef guard for folder creation.
Change text to indicate that enhanced broadcasting/MT does not have to configure multiple encodes, although it often/usually does.
`outputResolution` may not be editable and outputResolution->lineEdit() can return `nullptr` which causes crash.
Notable Changes: * deps.ffmpeg: Update AOM to 3.13.1 * deps.windows: Add VST3 SDK * deps.macos: Add VST3 SDK * utils.zsh: Enable debug symbols for ObjC * deps.ffmpeg: Update nv-codec to n13.0.19.0 * deps.ffmpeg: Update AMF to 1.5.0 * deps.ffmpeg: Update FFmpeg to 8.1 * deps.macos: Update qrcodegen-cmake to v1.8.0-cmake4 * deps.macos: Update Sparkle to 2.9.1 * deps.qt: Update Qt to 6.10.3 for Windows * deps.qt: Update Qt to 6.10.3 for macOS * deps.ffmpeg: Enable PDBs for FFmpeg builds on Windows * deps.ffmpeg: Update libdatachannel to v0.24.2
libdatachannel v0.24.0 added ice-tcp support. This allows OBS to publish WebRTC traffic over UDP or TCP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update deps with libdatachannel with ice-tcp support