fix(ui): descriptor-driven filters for composed boards - #9
Open
Seanathon wants to merge 1 commit into
Open
Conversation
…on's A composed grid board inherits type 'inspiration' for its card layout, so the navbar showed Inspiration's fixed Audience/Form/Domain facets (populated from Inspiration's taxonomy) and its design tag cloud — both irrelevant/empty for, say, a 'Wish List'. The board's tags never populated. Wire up the descriptor-driven filter helpers that already existed but were never used by the UI (Story 8.2: buildFilters + matchesFilters — 'a composed board filters with no code'): - collectionChrome: the FIXED Inspiration controls are now keyed to the SEEDED Inspiration board by id, not any type==='inspiration' board. Library controls likewise gate on the seeded ids. - applyCollectionChrome renders, for composed boards, a dropdown per enum field and a tag cloud from the tags field (via buildFilters). - applyFilters filters composed boards through matchesFilters (enum equality + tags includes, shape-bridged) plus a generic text search. - board switch + Clear reset the new selections. Verified live on a 'Wish List': Want level / Verdict dropdowns + a category tag cloud, and clicking a tag filters correctly. tsc clean; 534 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: when you create a new board (e.g. a "Wish List"), the navbar's filters showed the same options as Inspiration (Audience / Form / Domain) and the tag cloud never populated.
Cause: a composed grid board inherits
type: "inspiration"for its card layout, and the filter chrome keyed off that type — so it rendered Inspiration's fixed facets (populated from Inspiration's taxonomy) and its design tag cloud (readsmeta.tags, which composed items don't have).Fix: wire up the descriptor-driven filter helpers that already existed but were never used by the UI (Story 8.2's
buildFilters+matchesFilters— "a composed board filters with no code"):collectionChrome: the fixed Inspiration controls now gate on the seeded Inspiration board by id, not anytype === 'inspiration'board (Library controls likewise).applyCollectionChromerenders, for composed boards, a dropdown perenumfield and a tag cloud from thetagsfield.applyFiltersfilters composed boards throughmatchesFilters(enum equality + tags-includes, shape-bridged viagetFieldValue), plus a generic text search.Seeded Inspiration/Library keep their hand-tuned bespoke chrome (unchanged).
Verified live on a Wish List board: Want level + Verdict dropdowns and a category tag cloud now appear, and clicking a tag filters to the matching items.
tscclean; 534 tests pass.🤖 Generated with Claude Code