chore(deploy): typecheck deploy_tee in CI#39
Merged
Conversation
Fix the ty diagnostics that blocked deploy_tee, then flip the Makefile so lint/format/typecheck all cover both packages (drop the temporary FMT_PKG split — deploy_tee is now clean for all three). Genuine fixes: - gcp/api.py: wait_for_extended_operation was annotated compute_v1.Operation, but it uses the ExtendedOperation API (.done()/.error) that the compute_v1 clients actually return. Correcting the annotation clears 11 diagnostics. - summit_client._get_json: annotate -> Json; it returns response.json(), not str (the wrong annotation broke keys["..."]). - azure/api.py: str(image_path) in the azcopy command (list[str]); get_nsg_rules returns tuples, not list[str]. - measurements: replace the deprecated tempfile.mktemp with NamedTemporaryFile. Suppressed (type-checker limitation, test-only): two `# ty: ignore` on **kwargs dict-splats into typed params in test_manifest. These are annotation/tooling changes only — no behaviour change. `make check` is green on both packages; 28 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the ty diagnostics that blocked deploy_tee, then flip the Makefile so lint/format/typecheck all cover both packages (drop the temporary FMT_PKG split — deploy_tee is now clean for all three).
Genuine fixes:
Suppressed (type-checker limitation, test-only): two
# ty: ignoreon **kwargs dict-splats into typed params in test_manifest.These are annotation/tooling changes only — no behaviour change.
make checkis green on both packages; 28 tests pass.