feat(deploy_tee)!: merge network manifest into config at POST time#44
Merged
Conversation
`seismic-tee configure` gains a required --manifest. It merges the network-wide manifest into the per-node TOML (as [network].manifest_base64) and POSTs the result, replacing the old flow where the operator pre-embedded [network] into each node.toml. The manifest is one shared artifact across the cohort, so keeping it out of per-node tomls avoids copy-paste and drift. Pairs with tdx-init now requiring [network] (a manifest-less POST 400s). build_merged_config rejects a node.toml that already carries [network] (single source of truth) and validates the manifest schema before POSTing, so bad bytes fail locally instead of at the node. node.toml stays manifest-free ([domain] + [enclave]); the merge writes a throwaway temp config. Drop the now-obsolete `manifest embed` subcommand + embed_into_config: it mutated node.toml to carry [network], which configure now rejects — a subcommand whose output the pipeline refuses. configure merges instead, reusing render_network_section / validate_manifest_schema. Docs: update README command sequences + schema section and the seismic_node README (also fix its backwards "tdx-init waits for luks-setup" note); fix stale SeismicSystems/tdx-init references to the enclave crate (tdx-init now lives at enclave/crates/tdx-init). Add test_configure.py (merge / reject-pre-existing-[network] / reject-invalid-manifest); trim the embed test from test_manifest.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seismic-tee configuregains a required --manifest. It merges the network-wide manifest into the per-node TOML (as [network].manifest_base64) and POSTs the result, replacing the old flow where the operator pre-embedded [network] into each node.toml. The manifest is one shared artifact across the cohort, so keeping it out of per-node tomls avoids copy-paste and drift. Pairs with tdx-init now requiring [network] (a manifest-less POST 400s).build_merged_config rejects a node.toml that already carries [network] (single source of truth) and validates the manifest schema before POSTing, so bad bytes fail locally instead of at the node. node.toml stays manifest-free ([domain] + [enclave]); the merge writes a throwaway temp config.
Drop the now-obsolete
manifest embedsubcommand + embed_into_config: it mutated node.toml to carry [network], which configure now rejects — a subcommand whose output the pipeline refuses. configure merges instead, reusing render_network_section / validate_manifest_schema.Docs: update README command sequences + schema section and the seismic_node README (also fix its backwards "tdx-init waits for luks-setup" note); fix stale SeismicSystems/tdx-init references to the enclave crate (tdx-init now lives at enclave/crates/tdx-init).
Add test_configure.py (merge / reject-pre-existing-[network] / reject-invalid-manifest); trim the embed test from test_manifest.py.