feat(deploy_tee)!: configure injects [domain] from descriptor + --email#46
Merged
Conversation
node.toml now carries [enclave] only. configure assembles the POSTed config by appending two tables it owns: [domain] (name ← the descriptor's fqdn, the cert domain; email ← --email, default ops@seismic.systems) and [network] (← --manifest). This kills the fqdn duplication that broke cert issuance — the cert domain now comes from the same place that created the DNS record, so they can't drift (the mismatch was an NXDOMAIN certbot failure cascading to reth + summit). fqdn is now a required descriptor key (no public_ip fallback — a cert domain must resolve). configure rejects a node.toml carrying [domain] or [network], catching stale templates. The merge stays a plain text append (node.toml comments preserved), so render_network_section is unchanged. Templates drop [domain]; README updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node.toml now carries [enclave] only. configure assembles the POSTed config by appending two tables it owns: [domain] (name ← the descriptor's fqdn, the cert domain; email ← --email, default ops@seismic.systems) and [network] (← --manifest). This kills the fqdn duplication that broke cert issuance — the cert domain now comes from the same place that created the DNS record, so they can't drift (the mismatch was an NXDOMAIN certbot failure cascading to reth + summit).
fqdn is now a required descriptor key (no public_ip fallback — a cert domain must resolve). configure rejects a node.toml carrying [domain] or [network], catching stale templates. The merge stays a plain text append (node.toml comments preserved), so render_network_section is unchanged.
Templates drop [domain]; README updated.