fix(deploy_tee): stop exposing reth RPC/WS + dead prometheus port in NSG#49
Merged
Conversation
nginx terminates TLS on 443 and reverse-proxies /rpc and /ws to reth over loopback, so opening 8545/8546 in the NSG only bypassed nginx and exposed reth's --http.api all (admin/debug/txpool) to the internet in the clear. The 9090 "prometheus" rule was dead — summit's metrics are on 9002 (behind nginx /metrics/summit) and reth's on 127.0.0.1:9001. Rename OPEN_PORTS to OPEN_TCP_PORTS since the list is TCP-only (a future reth devp2p UDP discovery port would need its own list + rules). Also fix a stale RPC-method name in a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nginx terminates TLS on 443 and reverse-proxies /rpc and /ws to reth over loopback, so opening 8545/8546 in the NSG only bypassed nginx and exposed reth's --http.api all (admin/debug/txpool) to the internet in the clear. The 9090 "prometheus" rule was dead — summit's metrics are on 9002 (behind nginx /metrics/summit) and reth's on 127.0.0.1:9001. Rename OPEN_PORTS to OPEN_TCP_PORTS since the list is TCP-only (a future reth devp2p UDP discovery port would need its own list + rules). Also fix a stale RPC-method name in a comment.