ci: trigger binary release on semrel tag push#24
Closed
mwaldheim wants to merge 1 commit into
Closed
Conversation
GITHUB_TOKEN cannot trigger other workflows via tag push (GitHub security restriction). Explicitly dispatch release.yml via `gh workflow run` so binaries are built and GitHub Releases are created for every new semrel tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: After
semrelcreates a tag,release.ymlis supposed to build binaries and publish a GitHub Release. However, tag pushes viaGITHUB_TOKENdo not trigger other workflows (GitHub security restriction). As a result, tags v0.3.x exist but no GitHub Releases were created.Fix: After the tag is pushed, explicitly dispatch
release.ymlfor that tag viagh workflow run --ref $TAG.release.ymlalready supportsworkflow_dispatch, so this wires the two workflows together correctly.