Phase 1: GUI search completion — clear button, Enter key, safe UTF-8, tests - #286
Open
mark-e-deyoung wants to merge 1 commit into
Open
Phase 1: GUI search completion — clear button, Enter key, safe UTF-8, tests#286mark-e-deyoung wants to merge 1 commit into
mark-e-deyoung wants to merge 1 commit into
Conversation
…version, tests - Add ID_CLEAR_SEARCH_BTN with ✕ owner-draw button next to search edit - Add WM_KEYDOWN handler for Enter key in search edit (immediate refresh) - Add clearSearch() method: empties edit, restores full tree, hides clear button - Add EM_SETCUEBANNER placeholder text: Search windows... - Fix wide string conversion: use WideCharToMultiByte instead of iterator cast - Fix search error handling: check ok field, graceful disconnect message - Add 2 new doctest test cases: search returns matches, failed search handling - Reposition daemon indicator to avoid overlap with clear button - Build: zero warnings, all tests passing Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1: Search & Refresh Polish
Completes the in-progress search feature with proper UX.
Changes
✕) — appears next to search edit when text is present, clears and restores treeEM_SETCUEBANNER)WideCharToMultiBytereplaces unsafe iterator castokfield in search response, graceful disconnect messageTest Coverage (2 new doctest cases)
ViewModel search returns filtered matches— verifies FakeTransport search contractViewModel handles failed search gracefully— verifies error pathwayBuild Verification
feat/gui-search-tabsFiles Changed
clients/gui/src/gui_main.cpp— search UI controls, Enter key, clearSearch(), safe conversionclients/gui/tests/test_viewmodel.cpp— FakeTransport search handler, 2 search tests