Phase 2: GUI window table view with sub-tabs - #287
Open
mark-e-deyoung wants to merge 2 commits into
Open
Conversation
…version, tests - Add ID_CLEAR_SEARCH_BTN with ✕ owner-draw button next to search edit - Add WM_KEYDOWN handler for Enter key in search edit (immediate refresh) - Add clearSearch() method: empties edit, restores full tree, hides clear button - Add EM_SETCUEBANNER placeholder text: Search windows... - Fix wide string conversion: use WideCharToMultiByte instead of iterator cast - Fix search error handling: check ok field, graceful disconnect message - Add 2 new doctest test cases: search returns matches, failed search handling - Reposition daemon indicator to avoid overlap with clear button - Build: zero warnings, all tests passing Co-Authored-By: Claude <noreply@anthropic.com>
…lumnar ListView - Replace hTree_ (TreeView) with hWindowTable_ (ListView in report mode) - Add sub-tab bar: All Windows / Visible Only / By Process / UIA Tree - Add Inspect and Focus action buttons alongside existing Highlight - Add onInspectWindow() — calls window.getInfo, populates property panel - Add onFocusWindow() — calls window.ensureForeground RPC - Add getSelectedHwnd() helper for ListView-based selection - Update onNotify: replace TVN_SELCHANGEDW with LVN_ITEMCHANGED - Update onSize: position sub-tab bar, action buttons, window table - Update refreshImpl: populate ListView instead of TreeView - Update onDrawItem: add sub-tab button highlighting (active accent) - Remove addNode(), onTreeCustomDraw(), hwnd_storage_, hTree_ - Add 2 new doctest tests: listTop returns flat array, getInfo property map - Build: zero warnings, all 6 GUI viewmodel tests passing Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2: Window Table View + Sub-Tabs
Replaces the TreeView with a columnar ListView matching the mockup spec, adds sub-tab filtering, and adds window action buttons.
Changes
hTree_TreeView withhWindowTable_ListView (HWND + Title columns)window.getInfo), Focus (callswindow.ensureForeground)onInspectWindow()— dispatcheswindow.getInfo, populates right-side property panelonFocusWindow()— dispatcheswindow.ensureForeground, brings window to frontgetSelectedHwnd()— shared helper reading from ListView selectionaddNode(),onTreeCustomDraw(),hwnd_storage_,hTree_(all TreeView infrastructure)Test Coverage (6 total, +2 new)
ViewModel window.listTop returns hwnd array— verifies flat list contractViewModel window.getInfo returns property map— verifies hwnd/class_name/pid presentBuild Verification
feat/gui-window-tableFiles Changed
clients/gui/src/gui_main.cpp— ListView, sub-tab bar, action buttons, remove TreeViewclients/gui/tests/test_viewmodel.cpp— 2 new tests for list/getInfo contracts