build: enable MSVC exception unwinding - #295
Draft
mark-e-deyoung wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #294.
Stacked on #293 so the complete suite can run with isolated credential storage.
What changed
Adds MSVC
/EHscexplicitly alongside the existing/WXpolicy.Root cause
Fresh Visual Studio CMake configurations in the current toolchain generated empty
CMAKE_CXX_FLAGS. Cached local builds retained/EHsc, masking the problem. Without unwind semantics, standard-library exception handlers emit C4530, and/WXcorrectly turns that warning into a hard failure.Why this fix
/EHscis MSVC's standard C++ exception model for code that uses standard-library exceptions. Suppressing C4530 or disabling warnings-as-errors would hide a real compiler-contract mismatch.Validation
CMAKE_CXX_FLAGS/W3 /WXFormal-method assessment
No formal-model update is appropriate: the compiler exception ABI is a build invariant, not a runtime state-machine transition. The relevant control is a clean-cache build gate; formal trace replay runs in
test_coreand passed.