Fix/vanish scroll#244
Merged
TrevorBurgoyne merged 3 commits intomainfrom May 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a browser-specific interaction bug where middle-click dragging could trigger the browser’s auto-scroll instead of ULabel’s pan behavior when a subtask is vanished, and adds E2E coverage around zoom/pan behaviors plus CI improvements for Playwright.
Changes:
- Update
handle_mouse_downtopreventDefault()for drag starts and allowpan/zoomdrags even when the subtask is vanished. - Add a new Playwright E2E spec covering wheel zoom, pan gestures, and vanished-state interaction restrictions.
- Bump version to
0.23.5, update changelog, and add Playwright browser caching in CI.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/zoom-pan.spec.js | Adds E2E tests for zoom/pan and vanished-state drag behavior. |
| src/index.js | Adjusts mouse down handling to suppress browser defaults and permit pan/zoom while vanished. |
| src/version.js | Bumps exported library version to 0.23.5. |
| package.json | Bumps package version to 0.23.5. |
| CHANGELOG.md | Adds 0.23.5 release notes entry. |
| .github/workflows/test.yml | Adds Playwright browser caching to speed up CI runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR Checklist
package.jsonhas been bumped since last releasepackage.jsonandsrc/version.jsapi_spec.md)changelog.mdBreaking API Changes
No