feat: customizable STS endpoint#91
Open
vladosentinelus wants to merge 3 commits intoSentinel-One:masterfrom
Open
feat: customizable STS endpoint#91vladosentinelus wants to merge 3 commits intoSentinel-One:masterfrom
vladosentinelus wants to merge 3 commits intoSentinel-One:masterfrom
Conversation
Add sts_endpoint: Option<String> to Role and AccessKey variants so operators can point sts:AssumeRole calls at a non-default STS URL (mock STS for testing, GovCloud, private-link, compliance proxy). When unset, behaviour is unchanged.
vladosentinelus
commented
May 4, 2026
aayushoj-s1
reviewed
May 4, 2026
| /// When set, overrides the default STS endpoint (e.g. `sts.amazonaws.com`). | ||
| /// Useful for GovCloud, private-link setups, or pointing at a mock STS in tests. | ||
| /// When unset, the AWS SDK default is used — no behaviour change for existing configs. | ||
| #[configurable(metadata(docs::examples = "http://localhost:4566"))] |
There was a problem hiding this comment.
Let's not use localhost in docs string
aayushoj-s1
reviewed
May 4, 2026
| .time_source(SystemTimeSource::new()); | ||
| if let Some(endpoint) = sts_endpoint { | ||
| config_builder = config_builder.endpoint_url(endpoint); | ||
| } |
There was a problem hiding this comment.
use [set_endpoint_url](https://docs.rs/aws-sdk-s3/latest/aws_sdk_s3/config/struct.Builder.html#method.set_endpoint_url) here
| /// When set, overrides the default STS endpoint (e.g. `sts.amazonaws.com`). | ||
| /// Useful for GovCloud, private-link setups, or pointing at a mock STS in tests. | ||
| /// When unset, the AWS SDK default is used — no behaviour change for existing configs. | ||
| #[configurable(metadata(docs::examples = "http://localhost:4566"))] |
Contributor
|
@vladosentinelus can you please update the branch name to avoid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.