fix: make delete_sandbox idempotent when data plane returns "sandbox not found"#89
Draft
fix: make delete_sandbox idempotent when data plane returns "sandbox not found"#89
Conversation
…ot found Agent-Logs-Url: https://github.com/Serverless-Devs/agentrun-sdk-python/sessions/82dd0492-f264-497a-9397-ffb5e79a1d90 Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix list_sandboxes returning TERMINATED instances when deleting
fix: make delete_sandbox idempotent when data plane returns "sandbox not found"
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Control plane (
list_sandboxes) and data plane (delete_sandbox) can diverge: a TERMINATED sandbox remains visible in list results, but the data plane has already removed it, causingdelete_sandboxto raiseClientError('Failed to stop sandbox: sandbox not found')instead of succeeding silently.Changes
agentrun/sandbox/client.py— In bothdelete_sandboxanddelete_sandbox_async, when the data plane returns a non-SUCCESS response with a message containing"sandbox not found", return aSandboxwith the givensandbox_idinstead of raising. Existing HTTP-level 404 handling (raisesResourceNotExistError) is unchanged.tests/unittests/sandbox/test_client.py— Addedtest_delete_sandbox_not_found_in_response_is_idempotentand its async counterpart covering the new code path.Before / After