Fix onPageChanged handler not firing#36
Open
alexmitchelldev wants to merge 1 commit into
Open
Conversation
Fix onPageChanged handler not firing in pdfJsViewer The onPageChanged handler was defined in pdfJsViewer.spec but never wired up in the AngularJS directive, so the event never fired. Added handlers scope binding and registered a pagechanging listener on the PDF.js eventBus. The handler is called directly without $scope.$apply() to avoid digest cycle collisions during upward page navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests fixes an issue with the onPageChanged event not firing.
Summary
onPageChangedhandler was defined inpdfJsViewer.specbut never wired up in the AngularJS directive (pdfJsViewer.js), so the event never fired.handlers: "=svyHandlers"to the directive's scope bindings to expose handler functions.pagechanginglistener on the PDF.jseventBusinsiderenderFinished(), calling the handler directly without$scope.$apply()to avoid digest cycle collisions that prevented the event from firing during upward page navigation.