Add autogen for AMDC article in control with AMDC folder#151
Add autogen for AMDC article in control with AMDC folder#151Daehoon-Sung wants to merge 115 commits into
Conversation
Updated the document to focus on Simulink automatic code generation for AMDC, including calibration methods, procedures, and integration with AMDC.
Updated the steps for creating and configuring a Simulink model, including detailed instructions for setting up a reference model and generating C-code.
Clarified the Simulink and AMDC workflow, emphasizing the separation of control development into design and execution domains. Added details about the subsystems in the Simulink model.
…://github.com/Severson-Group/docs.amdc.dev into feature/add-autogen-control-with-AMDC-article
|
Hello @elsevers, the AMDC article of Autogen is ready. See the following rendered articles:
I think we can have better block diagram for the article, but we can discuss. |
|
Hello @elsevers, I updated the file organization for
|
|
Thanks @noguchi-takahiro. I have it on my queue. |
|
Following up on out 5/11 meeting:
|
|
Hello @elsevers, I have addressed the item 1 in this comment. See the following rendered articles:
I also updated the index so that those contents show up on the left banner. @Daehoon-Sung regarding the following comment, can you take a few minutes to review this discussion and make sure if we addressed all of these within the autogen article?
My takeaway is we already addressed these but I wanted to double check this with you. |
mhmokhtarabadi
left a comment
There was a problem hiding this comment.
Thank you @Daehoon-Sung and @noguchi-takahiro for this nice article. I have some inline comments. Feel free to comment on what you think if you don't like my suggestions.
| ```MATLAB | ||
| samplingFrequency_Hz = 10e3; % sampling frequency (Hz) | ||
| samplingTime_s = 1/samplingFrequency_Hz; % sampling time (s) | ||
| simulationTime_s = samplingTime_s/10; % simulation time (s) | ||
|
|
||
| omegaElec_radps = 377.0; % electrical angular velocity (rad/s) | ||
| dutyAmplitude = 0.8; % amplitude of the duty-ratio waveform (--) | ||
| ``` |
There was a problem hiding this comment.
@noguchi-takahiro, do you think we should follow PR https://github.com/Severson-Group/KnowledgeBase/pull/366 as the reference for naming the variables here?
There was a problem hiding this comment.
Thank you @mhmokhtarabadi, can I request you to update naming convention for both setup.m and setup_model.slx and generate_duty.slx for me?
Co-authored-by: Mohamadhasan <70004596+mhmokhtarabadi@users.noreply.github.com>
…://github.com/Severson-Group/docs.amdc.dev into feature/add-autogen-control-with-AMDC-article
|
Thank you @mhmokhtarabadi. I addressed your feedback. Can you kindly update naming convention based on this latest article here or https://github.com/Severson-Group/KnowledgeBase/pull/366? |
This is to close #143 to close #149 to close https://github.com/Severson-Group/AMDC-Examples/issues/6.
Notes
This comment might be useful to refer to how we came up with the plan for those two ariticles.
Self-Review
In this section, please self-review (answer all questions) on a suitable review checklist prior to requesting review from others. Select a review checklist based on what content is being merged in; see the Review Checklists section.
Reviewer Instructions
Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.
Appendix
This section should be the same for all PRs. Do not edit this section when creating a PR.
Review Checklists
Checklists maintained by the eLev lab for research repositories include:
Standard checklist