Fix datepicker overlay click intercept - #19
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the risk of Money Forward’s datepicker overlay intercepting the “保存” (submit) click by adding a pre-submit UI stabilization step that attempts to close the datepicker after date entry.
Changes:
- Add
closeDatepickerBeforeSubmit(Escape + blur + short wait for datepicker invisibility) in a newsrc/ui-stability.jsmodule. - Invoke the new UI-stabilization step in
importTransactionsjust before clicking the submit button. - Add a unit test for the new helper and update docs (README + test spec) to describe the behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
test/ui-stability.test.js |
Adds unit tests validating the helper’s step order and error-swallowing behavior. |
src/ui-stability.js |
Introduces the datepicker close + wait helper used to stabilize UI before submit. |
src/import-paypay-to-mfme.js |
Calls the new helper after filling the date field and before submit click. |
README.md |
Documents the new “close datepicker before save” behavior and adjusts process description. |
docs/test-spec.md |
Adds a UI-stability test perspective/case entry for the datepicker close behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Set per-step timeouts Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Update the spec to point to the actual unit under test Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…nterference and improve error diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
変更内容
動作確認
チェックリスト