fix(app-bridge-react): stabilize SaveBar and Modal ref callbacks - #577
Merged
henrytao-me merged 2 commits intoAug 24, 2026
Merged
Conversation
henrytao-me
approved these changes
Aug 24, 2026
Changelog CI requires a changeset. Patch bump for Shopify#565. Assisted-By: devx/35dc5d8f-6f30-4363-8095-9b09c36e51fe
andrewiggins
approved these changes
Aug 24, 2026
Member
|
Thanks @HamedFarazi for sending the PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #565
SaveBar and Modal were creating a new inline ref callback on every render.
React treats changing callback refs as detach/attach operations, causing the
ref callback to run repeatedly and trigger internal state updates.
Changes
useCallbackrefsValidation
Only modified: