refactor: clean up imports and formatting in command files - #10
Merged
Conversation
- Consolidated import statements for `createSpinner` across multiple command files for consistency. - Improved formatting in `package.json` for `files` and `keywords` arrays for better readability. - Minor adjustments in test files to enhance code clarity.
- Added `setupFiles` to Vitest configuration for improved test initialization. - Disabled file parallelism in Vitest to ensure sequential test execution. - Introduced `resetConfigMock` function in test utilities to reset configuration state before each test. - Updated multiple test files to utilize `beforeEach(resetConfigMock)` for consistent test setup.
- Modified `setupFiles` path in Vitest configuration for better compatibility. - Added a `pool` option to Vitest configuration to enhance performance. - Updated `tests/README.md` to include information about optional smoke tests.
- Introduced a new `test:smoke` command in `package.json` for running smoke tests. - Updated smoke test documentation to clarify execution context and CI behavior. - Added `docs/ignored/` to `.gitignore` to exclude ignored documentation files.
- Reformatted smoke test cases for better readability and consistency. - Ensured consistent indentation and structure across all test cases. - No functional changes were made to the tests themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createSpinneracross multiple command files for consistency.package.jsonforfilesandkeywordsarrays for better readability.Description
PR guidelines
CI will run the following. Please ensure they pass locally before requesting review:
pnpm lintpnpm typecheckpnpm testpnpm test:coverage(must meet thresholds)pnpm changeset(for user-facing changes only)If you added or changed a command, run
pnpm docs:generateand commit the updateddocs/COMMANDS.md.