♻️ Oversized file cleanup — deferred splits (close #14) - #15
Merged
Conversation
The masked comparison (segments()[1] & 0xfff0) == 0x0db8 could never be true (0x0db8 & 0xfff0 == 0x0db0), leaving the 2001:db8::/32 documentation range unblocked. Compare both /32 segments exactly instead. Same defect existed in the duplicated guard in driver http_signing; both are fixed and covered by a new unit test.
Pure mechanical move of adapter/src/processor/account.rs into a directory module; no behavior change.
Remove confirmed-dead metadata use-case traits and implementations while retaining projection and rehydration behavior; no behavior change for reachable code.
Remove confirmed-dead profile use-case traits and implementations while retaining projection and image-resolution behavior; no behavior change for reachable code.
…ibility Pure mechanical move of server/src/route/activitypub.rs into a directory module; no behavior change.
Pure mechanical move of server/src/route/oauth2.rs into a directory module; no behavior change.
…nd tests Pure mechanical move of driver/src/database/postgres/account.rs into a directory module; no behavior change.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 64.76% 64.53% -0.23%
==========================================
Files 116 147 +31
Lines 15203 14400 -803
==========================================
- Hits 9846 9293 -553
+ Misses 5357 5107 -250 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Issue #14 の延期リスト全件への対応。全て機械的分割・監査済み死コード削除であり、到達可能コードの挙動変更はありません。
close #14
変更内容
先行バグ修正(ベースライン clippy エラーの解消、ユーザー承認済み)
94b9aaa🐛 SSRF フィルタの IPv6 documentation range (2001:db8::/32) チェックが恒 false になっていたバグを修正(application/driver の重複箇所両方、単体テスト追加)分割(#13 と同一規約の directory module 化)
4b3d826adapterprocessor/account.rs(435行) →account/{mod,command,query}.rs(7つの公開パスは再エクスポートで維持)4ca9be6serverroute/activitypub.rs(532行) →activitypub/{mod,discovery,actor,collections,inbox}.rs6431ddfserverroute/oauth2.rs(897行) →oauth2/{mod,login,consent}.rs9eda8c6driverpostgres/account.rs(784行) →account/{mod,row,tests}.rs(SQL リテラルはバイト同一を検証済み。impl ブロックは分割せず row マッピングとテストを抽出)利用監査の結果: 分割ではなく死コード削除
account_detail 導入により call site がゼロになっていた UseCase trait を削除(Issue の「利用監査の実施」トリガーに対応):
14bab0cservice/metadata.rs: Get/Create/Update/DeleteMetadataUseCase 削除(420→110行)。UpdateMetadata/rehydrate_metadataは applier/account_detail が使用中のため保持7c1aa22service/profile.rs: Get/UpdateProfileUseCase 削除(326→116行)。UpdateProfile/resolve_field_action_image_id等は保持対象外(Issue 記載の方針通り)
server/src/handler.rs・kernel/src/entity/account.rs— サイズ例外として分割しないserver/tests/support/*.rs— fixture は ceiling 適用外検証
cargo build/cargo clippy --all-targets/cargo fmt --check: 全て exit 0cargo test: 全スイート 0 失敗(PostgreSQL/Redis 起動済み環境。postgres account の DB テスト8件は実 DB で実行して green)補足
削除により
transfer/{metadata,profile}.rsの DTO が dead-but-public になったが、スコープ外のため保持(後続クリーンアップ候補)。