fix(cla): skip CLA job for owner/bots (no spurious failures) - #24
Merged
Conversation
Job-level 'if' skips the CLA job for the Owner (bkd-dotcom) and dependabot on PR + comment events, so the required 'cla' check resolves (skipped=passed) without a manual recheck. Verified on umbra-core: owner PR merged non-admin with cla skipped. Real contributors still run the gate and must sign.
Umbra Reviewer — 🟣 Escalate to a designated reviewerEscalate to a designated reviewer — this PR touches security-sensitive surface (.github/workflows/cla.yml). No blocking issue was found automatically, but a human owner should sign off. Deterministic gates (the authority)
Findings (1, 0 blocking)
Sensitive surfaceThis PR changes security-sensitive paths that warrant a designated reviewer:
MergeA designated reviewer / code owner should sign off before merge (sensitive surface).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLA action flagged even the allowlisted owner on the initial
pull_request_targetrun (only arecheckcleared it). This job-levelifskips the CLA job for the Owner + dependabot so their requiredclacheck resolves without manual rechecks. Verified on umbra-core: owner PR merged non-admin withclaskipped; real contributors still run the gate. Workflow-only.