release: v0.2.0 — signetry-reviewer - #20
Merged
Merged
Conversation
The dependency-skew check (#16, #19) plus the CI-comment false-positive fix (#18). Minor bump rather than patch because a new deterministic check landed, not just fixes. Also fixes a stale pin: action.yml fell back to @v0.1.1 even after v0.1.2 shipped, so any workflow not setting signetry-reviewer-version silently installed a release behind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump + changelog so the fixes and the new check can actually reach the field —
Signetry/core's workflow installs this by tag, so nothing merged since v0.1.2 is live yet.What's in it
Added
supply.dependency_skew— lockfile changed without its manifest (Check: flag a lockfile change without a corresponding manifest change #16, feat(checks): flag a lockfile change with no manifest change #19). Advisory, but MEDIUM so it withholds auto-merge.Fixed
pull_request_target(fix(checks): CI rules fired on YAML comments; tighten pull_request_target to the real trigger #18)ci.pull_request_targetnow matches the real trigger in all four YAML forms (fix(checks): CI rules fired on YAML comments; tighten pull_request_target to the real trigger #18)dependency_skew_okgate was dead — referenced in three places, produced by nothing, so every "Dependency skew ✅ ok" row was meaningless (feat(checks): flag a lockfile change with no manifest change #19)blockingflag, which would have hard-blocked every Dependabot PR once the check existed (feat(checks): flag a lockfile change with no manifest change #19)action.ymlfell back to@v0.1.1even after v0.1.2 shipped, so a workflow that didn't setsignetry-reviewer-versionsilently installed a release behindWhy minor, not patch
A new deterministic check is a feature, so
0.1.2 → 0.2.0.After merge
git tag v0.2.0 && git push origin v0.2.0, then bump thesignetry-reviewer@pin inSignetry/core'sreviewer.yml(and the other repos that install it) so the comment fix and the skew check take effect.