feat(tv): add a manual Up Next control to the player transport - #110
Conversation
Ports silo-apple#86. Android TV already surfaced Up Next automatically at the credits, but there was no way to reach it early — a viewer who is done with an episode had to sit through the outro or leave the player and navigate back in. The control appears in the transport's secondary group only when a next episode is actually resolved, and the predicate lives on the view model so the manual button and the automatic trigger cannot disagree about whether there is anything to advance to. A button that appears when the automatic path would find nothing is a button that does nothing. It deliberately does NOT start the auto-advance countdown. Someone who opened this themselves is choosing; a timer that pulls them into the next episode mid-decision is the opposite of what the press asked for. The automatic path keeps its countdown and its pass-out gating untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Db4dSxN9tH8yN7uUP549tK
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Problem
Android TV surfaced Up Next automatically at the credits, but there was no way to reach it early. A viewer who is done with an episode had to sit through the outro or leave the player and navigate back in.
Ports Silo-Server/silo-apple#86, which added the equivalent control to the tvOS transport.
Change
A Skip-Next control in the transport's secondary group, shown only when a next episode is actually resolved.
The availability predicate lives on the view model (
canShowNextUpNow) and is shared with the automatic path, deliberately: a manual button that can appear when the automatic trigger would find nothing is a button that does nothing when pressed. Apple made the same call in #86 for the same reason.The one judgement call worth reviewing
It does not start the auto-advance countdown. Someone who opened Up Next themselves is choosing what to do next; a timer that pulls them into the following episode mid-decision is the opposite of what the press asked for. The automatic path keeps its countdown and its pass-out gating untouched — the only thing that differs between the two entry points is whether a countdown runs.
If the project would rather the manual path behave identically to the automatic one, that is a one-line change (
startNextUpCountdown()inonUserRequestedNextUp), but I think the asymmetry is right.Testing
:androidTvApp:assembleDebugand the TV unit suite green on this branch, based onupstream/main.Not exercised on hardware. The control is wired and the predicate is shared, but I have not watched an episode to the point of having a resolved next episode and pressed it.
AI-use disclosure
Written by Claude Opus 5 (Claude Code) working with @RXWatcher, who is tracking Apple/Android parity and directed this port.