fix(android): scope Room storage and outbox state (PR 108 slice C)

[RXWatcher]

Stack

• Base: draft PR fix(android): forward-split auth and EPUB security from PR 108 #113 (split/108-b-auth-epub)
• This is slice C of the forward split that supersedes closed, unmerged PR Integrate the fork: subtitles/PGS, Watch Together, security hardening, player and sync fixes #108.
• PR Integrate the fork: subtitles/PGS, Watch Together, security hardening, player and sync fixes #108 and integrate/ship-everything remain archival references.

Scope

• Room schema v8 and verified 7→8 migration coverage
• identity-contained downloads and JSON state
• removed-server purge with worker lifetime/cancellation barriers, retry evidence, and active-playback deferral
• JSON-only orphan discovery with no-follow/root/sibling-symlink defenses and writer/purge generation serialization
• explicit-scope download cancellation cleanup
• profile-triggered outbox drains and FIFO-before-limit ordering

Review corrections

Independent review findings were fixed test-first, including startup-removal loss, WorkManager acknowledgement vs worker completion, cancellation/storage failure retention, JSON-only discovery, root/sibling symlinks, stale-writer recreation, SQL page overtaking, and immediate profile changes. Final independent verdict: Ready: Yes; no Important findings.

Verification

• ./scripts/check-build-supply-chain.sh
• ./gradlew -Dorg.gradle.jvmargs="-Xmx4g -Dfile.encoding=UTF-8" testDebugUnitTest :androidApp:assembleRelease :androidTvApp:assembleRelease --max-workers=2
• Result at 387f3ce6: BUILD SUCCESSFUL, 334 tasks, 2m38s

Traceability: docs/notes/2026-07-27-pr108-slice-c-traceability.md

[coderabbitai]

Warning

Review limit reached

@RXWatcher, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 495b07d6-a761-473d-93f6-c802111b5d78

📥 Commits

Reviewing files that changed from the base of the PR and between 8152189 and 387f3ce.

📒 Files selected for processing (44)

• android-shared/build.gradle.kts
• android-shared/gradle.lockfile
• android-shared/schemas/org.siloserver.silo.common.data.db.SiloDatabase/8.json
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/audiobook/AudiobookBookmarksStore.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/data/db/SiloDatabase.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/data/db/dao/DirtyOperationDao.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/data/db/dao/ServerPurgeDao.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/data/db/entity/DownloadEntity.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/data/repository/RoomUserItemStateRepository.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/data/sync/OutboxSyncStarter.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/data/sync/SyncEngine.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/downloads/DownloadEnqueuer.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/downloads/DownloadSidecarMapping.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/downloads/DownloadStorage.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/downloads/DownloadWorker.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/downloads/DownloadWorkerLifetime.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/downloads/OrphanedServerDataPurger.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/ebook/EbookLocalStateStore.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/store/SafePathSegment.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/store/ScopedJsonFileStore.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/store/ServerScopedJsonAccess.kt
• android-shared/src/androidMain/kotlin/org/siloserver/silo/common/store/ServerScopedJsonStatePurger.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/data/db/SiloDatabaseMigrationTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/data/repository/RoomUserItemStateRepositoryTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/data/sync/OutboxSyncStarterScopeTriggerTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/data/sync/SyncEngineTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/downloads/DownloadStorageTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/downloads/DownloadWorkerLifetimeTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/downloads/MediaStorePublicDownloadStoreCollisionTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/downloads/OfflineMediaResolverTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/downloads/OrphanedServerDataPurgerTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/downloads/PublicDownloadRelativeRootTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/store/SafePathSegmentTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/store/ScopedJsonFileStoreTest.kt
• android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/store/ServerScopedJsonStatePurgerTest.kt
• androidApp/src/androidMain/kotlin/org/siloserver/silo/android/SiloApplication.kt
• androidApp/src/androidMain/kotlin/org/siloserver/silo/android/ui/screens/detail/ItemDetailViewModel.kt
• androidApp/src/androidMain/kotlin/org/siloserver/silo/android/ui/screens/downloads/DownloadsViewModel.kt
• androidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/SiloTvApplication.kt
• docs/notes/2026-07-27-pr108-slice-c-traceability.md
• docs/superpowers/plans/2026-07-27-pr108-slice-c-room-sync.md
• gradle/verification-metadata.xml
• shared/src/androidMain/kotlin/org/siloserver/silo/network/AndroidServerRegistry.kt
• shared/src/commonMain/kotlin/org/siloserver/silo/network/ServerRegistry.kt

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch split/108-c-room-sync

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}