Skip to content

fix(tv): remove aliased hairline border on player transport controls - #223

Merged
Quick104 merged 1 commit into
Silo-Server:mainfrom
evulhotdog:fix/tv-transport-hairline-aliasing
Aug 13, 2026
Merged

fix(tv): remove aliased hairline border on player transport controls#223
Quick104 merged 1 commit into
Silo-Server:mainfrom
evulhotdog:fix/tv-transport-hairline-aliasing

Conversation

@evulhotdog

@evulhotdog evulhotdog commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Why

The rest-state border on the player transport controls (play/pause, skip back and forward, subtitles, options, close) is a 0.5dp translucent white stroke at 22% alpha. Because it is thinner than a device pixel and translucent, it dithers against the moving video and aliases into a jagged white fringe around each button, visible even on 4K panels where the sub-pixel stroke never lands on a whole device pixel.

What

Drop the rest-state hairline border and let the translucent fill carry the button edge. Focus treatment (white-fill inversion) is unchanged.

Scope

Player screen only (TvPlayerTransportCluster.kt). No other screens are
affected.

Testing

Compiles clean (:androidTvApp:compileDebugKotlinAndroid) and manually validated that everything looks much cleaner.

Summary by CodeRabbit

  • Style
    • Updated TV player transport controls to use a cleaner focus highlight without a circular border.

The rest-state border on the player transport controls is a 0.5dp
translucent white stroke (22% alpha) drawn on each circular button.
Because it is thinner than a device pixel and translucent, it dithers
against the moving video and aliases into a jagged white fringe around
every button, visible even on 4K panels where the sub-pixel stroke never
lands on a whole device pixel.

Drop the rest-state border and let the translucent fill carry the button
edge. Focus treatment (white-fill inversion) is unchanged.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e40a84f-8c9d-4d63-8e3b-cd35e05ed833

📥 Commits

Reviewing files that changed from the base of the PR and between c10e96d and 3777c71.

📒 Files selected for processing (1)
  • androidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerTransportCluster.kt
💤 Files with no reviewable changes (1)
  • androidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerTransportCluster.kt

📝 Walkthrough

Walkthrough

The change removes the unused border import and the circular border modifier from TransportIconButton. Focus styling now uses the background color only.

Changes

Transport icon styling

Layer / File(s) Summary
Remove circular focus border
androidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerTransportCluster.kt
Removed the unused border import and the conditional circular border from TransportIconButton.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to 3777c

This change removes a localized visual artifact from the TV player controls without changing focus behavior or other screens; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the aliased hairline border from the TV player transport controls.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Quick104
Quick104 merged commit 8c8b603 into Silo-Server:main Aug 13, 2026
3 checks passed
@evulhotdog
evulhotdog deleted the fix/tv-transport-hairline-aliasing branch August 27, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants