fix(playback): handle rejected cleartext media origin - #234
Draft
Quick104 wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The media cleartext-origin guard threw an unchecked
IllegalStateExceptionfrom an OkHttp network interceptor. OkHttp delivered a cancellation to the callback and then rethrew the unchecked exception on its dispatcher thread, terminating the Android process when playback encountered an unapproved cleartext redirect.Approach
IOExceptionso OkHttp and Media3 handle it as a normal playback failure.Verification
./gradlew :android-shared:testDebugUnitTest --tests org.siloserver.silo.common.player.MediaAuthInterceptorTest --no-daemon --max-workers=2./gradlew :android-shared:testDebugUnitTest :androidApp:assembleDebug :androidTvApp:assembleDebug --no-daemon --max-workers=2git diff --checkAll tests passed, and both phone and TV debug APKs assembled successfully. An independent review found no correctness, privacy, or security issues.
Closes #233
AI-use disclosure
🤖 Generated with OpenAI Codex