fix(convert): preserve capability config forms - #14
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bd04a8878
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Problem
Capability config schemas lose their admin form when they pass through CapabilityRecordsFromManifest and DecodeCapability. Silo persists that record during plugin installation, so a watch-provider capability installed with a valid connection form is later discovered with only the scalar JSON schema and no renderable fields.
Part of Silo-Server/silo-server#549. Required by Silo-Server/silo-server#550.
Fix
This is an implementation fix only; it adds no protobuf fields and remains wire-compatible with v0.13.0 plugins and existing scalar-only capability records.
Live evidence
In an isolated dev-builder sandbox, the uploaded Floppy v0.2 manifest response contained config_schema.admin_form, but GET /api/v1/watch-providers returned the same schema without admin_form after capability persistence and reload. Inspection traced the loss to the converter scalar allowlist changed here.
Validation
Passed on commit 6bd04a8:
AI assistance disclosure