Skip to content

fix(convert): preserve capability config forms - #14

Merged
Quick104 merged 2 commits into
mainfrom
codex/capability-admin-form-roundtrip
Aug 6, 2026
Merged

fix(convert): preserve capability config forms#14
Quick104 merged 2 commits into
mainfrom
codex/capability-admin-form-roundtrip

Conversation

@Quick104

@Quick104 Quick104 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Problem

Capability config schemas lose their admin form when they pass through CapabilityRecordsFromManifest and DecodeCapability. Silo persists that record during plugin installation, so a watch-provider capability installed with a valid connection form is later discovered with only the scalar JSON schema and no renderable fields.

Part of Silo-Server/silo-server#549. Required by Silo-Server/silo-server#550.

Fix

  • serialize each complete ConfigSchema proto into capability metadata instead of copying a scalar allowlist
  • decode the complete stored schema back through protojson
  • retain forward compatibility by discarding unknown future fields during decode
  • assert full proto equality, including AdminFormDescriptor, across the record round trip

This is an implementation fix only; it adds no protobuf fields and remains wire-compatible with v0.13.0 plugins and existing scalar-only capability records.

Live evidence

In an isolated dev-builder sandbox, the uploaded Floppy v0.2 manifest response contained config_schema.admin_form, but GET /api/v1/watch-providers returned the same schema without admin_form after capability persistence and reload. Inspection traced the loss to the converter scalar allowlist changed here.

Validation

Passed on commit 6bd04a8:

  • go test -race ./...
  • go vet ./...
  • focused race tests for convert, manifest, and runtime
  • git diff --check

AI assistance disclosure

  • Tool: Codex
  • Model: gpt-5.6
  • Involvement: AI-assisted live diagnosis, implementation, compatibility review, and validation on behalf of repository maintainer Quick104.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7b2f9f43-31c5-4f20-88e1-cfec0fcacbe8

📥 Commits

Reviewing files that changed from the base of the PR and between 13d7ccc and 5894c99.

📒 Files selected for processing (2)
  • pkg/pluginsdk/convert/convert.go
  • pkg/pluginsdk/convert/convert_test.go

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bd04a8878

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pkg/pluginsdk/convert/convert.go
@Quick104
Quick104 merged commit 214cfe5 into main Aug 6, 2026
1 of 3 checks passed
@Quick104
Quick104 deleted the codex/capability-admin-form-roundtrip branch August 6, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant