fix(playback): restore SDR alternate fallback for burn-in subtitles - #623
Closed
cursor[bot] wants to merge 1 commit into
Closed
fix(playback): restore SDR alternate fallback for burn-in subtitles#623cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
#617 renamed HDR/4K burn-in refusals to subtitle_conversion_unsupported when the subtitle alone forced adaptation, but terminalAllowsAlternateFileV3 still only recognized the old HDR/4K reasons. Selecting a PGS track on an HDR source therefore skipped the SDR alternate and returned adaptation_unavailable. Co-authored-by: Quick <Quick104@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #617.
Selecting a bitmap (PGS/VOBSUB) subtitle on an HDR source that has an SDR alternate returned
adaptation_unavailablewithsubtitle_conversion_unsupportedinstead of falling back to the SDR version and burning the subtitle in.Concrete trigger:
Approach
#617 correctly renamed burn-in-only HDR/4K refusals to
subtitle_conversion_unsupportedso the UI can name the subtitle.terminalAllowsAlternateFileV3was not updated and still only treatedhdr_transcode_unsupported/no_alternate_versionas version-shaped blockers, so the existing alternate-file path never ran.Allow
subtitle_conversion_unsupportedthrough the same gate. Alternate selection remains opt-in (quality != original, track/quality/output/failure replan), remaps the subtitle identity, and only adopts the alternate when that plan succeeds. If no alternate works, the subtitle-named terminal still surfaces.Testing
TestHandleReplanPlaybackV3BitmapSubtitleFallsBackFromHDRToSDRVersionfailed on pristineee9356aa(#617) and passes with this change.AI Disclosure
subtitle_conversion_unsupportedshould trigger an alternate attempt. Trying once is safe: remapping can fail closed withsubtitle_unavailable_in_version, a failed alternate still surfaces the subtitle-named terminal, andquality=original/ seek-only replans remain pinned. Did not broaden planner reason naming from fix(playback): claim Safari DV/HDR10 decode evidence and preserve dvvC in remuxes #617.Checklist
gofmtand targetedgo testfor the touched packages. Fullmake lint/ web lint were not required (backend-only, two files).