Skip to content

Add option to select activation function for ChamberSphere#239

Open
charoheijnen wants to merge 2 commits into
SimVascular:masterfrom
charoheijnen:newchamber
Open

Add option to select activation function for ChamberSphere#239
charoheijnen wants to merge 2 commits into
SimVascular:masterfrom
charoheijnen:newchamber

Conversation

@charoheijnen

Copy link
Copy Markdown

Add option to select activation function for ChamberSphere

Current situation

Currently activation function is hard coded within ChamberSphere. As detailed in #236

Release Notes

  • added option to choose activation funciton to chambersphere block
  • added activaion funtion from chambersphere to activation funciton block

Testing

  • chambersphere test case still runs as previously when choosing double tanh activation funciton with parameters that were in previous test case.

Code of Conduct & Contributing Guidelines

…y of activation funcitons. Added double_tanh activation funciton to activation function file. Changed chamver_sphere.json test case to be able to choose activaiton function. when double_tanh activation funciton was selected test case runs as previously ran.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@KatrinKoesler
KatrinKoesler requested a review from mrp089 July 22, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant