Skip to content

MS-1491 Spoof check implementation #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luhmirin-s wants to merge 13 commits into
base: main
Choose a base branch
from
Open

MS-1491 Spoof check implementation #1735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ef7442d
MS-1491 Add temporary experimental config
luhmirin-s Jul 1, 2026
837b86a
MS-1491 Add spoof configuration to LiveFeedbackFragment
luhmirin-s Jul 1, 2026
dd14e55
MS-1491 Add spoof check to face detector API
luhmirin-s Jul 2, 2026
7830eef
MS-1491 Pass original bitmap from cropper to image processor
luhmirin-s Jul 2, 2026
b310b84
MS-1491 Add basic live data spoof checking and UI state handling
luhmirin-s Jul 2, 2026
3811bb2
MS-1491 Add spoof check result tracking to the capture event
luhmirin-s Jul 6, 2026
298abef
MS-1491 Move the max attempt into spoof check configuration
luhmirin-s Jul 6, 2026
510a8fa
MS-1491 Scale down images that are over configurable limit to ensure …
luhmirin-s Jul 7, 2026
1d0cc82
MS-1491 Display progress bar while running spoof checks (also in auto…
luhmirin-s Jul 7, 2026
61f8969
MS-1491 Add custom config for spoof check UI timings
luhmirin-s Jul 7, 2026
9f461ee
MS-1491 Remove debugging helpers from detector
luhmirin-s Jul 7, 2026
ea62fcd
MS-1491 Bitmap handling fixes
luhmirin-s Jul 7, 2026
467fefa
MS-1491 Mark spoofed captures in the capture event payload result
luhmirin-s Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions face/capture/src/main/java/com/simprints/face/capture/models/FaceDetection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ package com.simprints.face.capture.models
import android.graphics.Bitmap
import com.simprints.core.tools.time.Timestamp
import com.simprints.face.infra.basebiosdk.detection.Face
import com.simprints.face.infra.basebiosdk.detection.SpoofCheckResult
import com.simprints.infra.images.model.SecuredImageRef
import java.util.UUID

internal data class FaceDetection(
val original: Bitmap,
val bitmap: Bitmap,
val face: Face?,
val status: Status,
Expand All @@ -15,6 +17,7 @@ internal data class FaceDetection(
var isFallback: Boolean = false,
var id: String = UUID.randomUUID().toString(),
var detectionEndTime: Timestamp,
var spoofCheckResult: SpoofCheckResult? = null,
) {
enum class Status {
VALID,
Expand Down
11 changes: 6 additions & 5 deletions .../main/java/com/simprints/face/capture/screens/livefeedback/CropToTargetOverlayAnalyzer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ internal class CropToTargetOverlayAnalyzer(
private val previewRect: RectF,
private val overlayWidth: Int,
private val overlayHeight: Int,
private val onImageCropped: (Bitmap) -> Unit,
private val onImageCropped: (original: Bitmap, cropped: Bitmap) -> Unit,
) : ImageAnalysis.Analyzer {
override fun analyze(image: ImageProxy) {
val croppedBitmap = image.use {
val (originalBitmap, croppedBitmap) = image.use {
if (previewRect.isEmpty) return

// Adjust overlay size to be fit-center with the image size
Expand All @@ -37,15 +37,16 @@ internal class CropToTargetOverlayAnalyzer(
val cropTop = offsetY + (previewRect.top * scale).toInt()
val cropHeight = (previewRect.height() * scale).toInt()

Bitmap.createBitmap(
it.toBitmap(),
val imageBitmap = it.toBitmap()
imageBitmap to Bitmap.createBitmap(
imageBitmap,
cropLeft,
cropTop,
cropWidth,
cropHeight,
)
Comment thread
luhmirin-s marked this conversation as resolved.
}
onImageCropped(croppedBitmap)
onImageCropped(originalBitmap, croppedBitmap)
}

private fun getSmallerRatio(
Expand Down
76 changes: 58 additions & 18 deletions ...ure/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import androidx.camera.lifecycle.awaitInstance
import androidx.core.content.ContextCompat
import androidx.core.net.toUri
import androidx.core.view.isGone
import androidx.core.view.isInvisible
import androidx.core.view.isVisible
import androidx.fragment.app.Fragment
import androidx.fragment.app.activityViewModels
Expand Down Expand Up @@ -78,6 +79,9 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
private val defaultCaptureProgressColor: Int
get() = ContextCompat.getColor(requireContext(), IDR.color.simprints_blue_grey_light)

private val validationProgressColor: Int
get() = ContextCompat.getColor(requireContext(), IDR.color.simprints_orange)

private val launchPermissionRequest = registerForActivityResult(
ActivityResultContracts.RequestPermission(),
) { granted ->
Expand Down Expand Up @@ -181,7 +185,7 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
previewRect = RectF(binding.captureOverlay.circleRect), // create a new instance to avoid threading issues
overlayWidth = binding.captureOverlay.width,
overlayHeight = binding.captureOverlay.height,
onImageCropped = ::analyze,
onImageCropped = { original, cropped -> analyze(original, cropped) },
)

imageAnalyzer.setAnalyzer(cameraExecutor, cropAnalyzer)
Expand Down Expand Up @@ -255,6 +259,10 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
}

private fun bindViewModel() {
vm.progressBarValue.observe(viewLifecycleOwner) {
binding.captureProgress.value = it
}

vm.currentDetection.observe(viewLifecycleOwner) {
renderCurrentDetection(it)
}
Expand All @@ -263,6 +271,8 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
when (it) {
LiveFeedbackFragmentViewModel.CapturingState.NOT_STARTED -> renderCaptureNotStarted()
LiveFeedbackFragmentViewModel.CapturingState.CAPTURING -> renderCapturing()
LiveFeedbackFragmentViewModel.CapturingState.VALIDATING -> renderValidating()
LiveFeedbackFragmentViewModel.CapturingState.VALIDATION_FAILED -> renderResetAfterValidation()
LiveFeedbackFragmentViewModel.CapturingState.FINISHED -> {
mainVm.captureFinished(vm.sortedQualifyingCaptures)
findNavController().navigateSafely(
Expand All @@ -274,9 +284,12 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
}
}

private fun analyze(image: Bitmap) {
private fun analyze(
original: Bitmap,
cropped: Bitmap,
) {
try {
vm.process(croppedBitmap = image)
vm.process(originalBitmap = original, croppedBitmap = cropped)
} catch (t: Throwable) {
Simber.e("Image analysis crashed", t, tag = FACE_CAPTURE)
// Image analysis is running in bg thread
Expand All @@ -287,6 +300,10 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
}

private fun renderCurrentDetection(faceDetection: FaceDetection) {
if (vm.isAutoCapture && vm.capturingState.value != LiveFeedbackFragmentViewModel.CapturingState.CAPTURING) {
return
}

when (faceDetection.status) {
FaceDetection.Status.NOFACE -> renderNoFace()
FaceDetection.Status.OFFYAW -> renderFaceNotStraight()
Expand All @@ -304,23 +321,25 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
if (vm.isAutoCapture) {
captureFeedbackBtn.setText(IDR.string.face_capture_start_capture)
captureFeedbackBtn.isChecked = true
captureFeedbackBtn.isClickable = true
} else {
captureFeedbackBtn.setText(IDR.string.face_capture_title_previewing)
}

captureOverlay.drawSemiTransparentTarget()
captureFeedbackTxtExplanation.setTextColor(ContextCompat.getColor(requireContext(), IDR.color.simprints_text_white))

captureFeedbackBtn.isVisible = true
captureFeedbackPermissionButton.isGone = true
setManualCaptureButtonClickable(false)
captureFeedbackTxtExplanation.isGone = true
}
}

private fun renderCapturing() {
binding.apply {
captureOverlay.drawWhiteTarget()
captureFeedbackTxtExplanation.setTextColor(
ContextCompat.getColor(requireContext(), IDR.color.simprints_blue_grey),
)
captureFeedbackTxtExplanation.setTextColor(ContextCompat.getColor(requireContext(), IDR.color.simprints_blue_grey))
captureFeedbackTxtExplanation.isVisible = true

captureProgress.isVisible = true
captureFeedbackBtn.setText(IDR.string.face_capture_prep_begin_button_capturing)
Expand All @@ -330,6 +349,32 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
}
}

private fun renderValidating() {
binding.apply {
captureOverlay.drawWhiteTarget()

captureProgress.progressColor = validationProgressColor
captureProgress.isVisible = true

captureFeedbackBtn.setText(IDR.string.face_capture_title_validating)
captureFeedbackBtn.setCheckedWithLeftDrawable(false)
setManualCaptureButtonClickable(false)

captureFeedbackTxtExplanation.isVisible = false
}
}

private fun renderResetAfterValidation() {
binding.apply {
captureProgress.isInvisible = true
captureFeedbackBtn.setText(IDR.string.face_capture_title_validating_failed)

captureFeedbackTxtExplanation.setTextColor(ContextCompat.getColor(requireContext(), IDR.color.simprints_blue_grey))
captureFeedbackTxtExplanation.setText(IDR.string.face_capture_error_validating_failed)
captureFeedbackTxtExplanation.isVisible = true
}
}

private fun renderValidFace() {
binding.apply {
if (vm.isAutoCapture) {
Expand Down Expand Up @@ -361,7 +406,7 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
true,
ContextCompat.getDrawable(requireContext(), R.drawable.ic_checked_white_18dp),
)
renderProgressBar(false)
captureProgress.progressColor = validCaptureProgressColor
}
}

Expand All @@ -374,7 +419,7 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)

captureFeedbackBtn.setCheckedWithLeftDrawable(false)
setManualCaptureButtonClickable(false)
renderProgressBar(false)
captureProgress.progressColor = defaultCaptureProgressColor
}
}

Expand All @@ -387,7 +432,7 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)

captureFeedbackBtn.setCheckedWithLeftDrawable(false)
setManualCaptureButtonClickable(false)
renderProgressBar(false)
captureProgress.progressColor = defaultCaptureProgressColor
}
}

Expand All @@ -400,7 +445,7 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)

captureFeedbackBtn.setCheckedWithLeftDrawable(false)
setManualCaptureButtonClickable(false)
renderProgressBar(false)
captureProgress.progressColor = defaultCaptureProgressColor
}
}

Expand All @@ -413,7 +458,7 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)

captureFeedbackBtn.setCheckedWithLeftDrawable(false)
setManualCaptureButtonClickable(false)
renderProgressBar(false)
captureProgress.progressColor = defaultCaptureProgressColor
}
}

Expand All @@ -426,15 +471,10 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)

captureFeedbackBtn.setCheckedWithLeftDrawable(false)
setManualCaptureButtonClickable(false)
renderProgressBar(false)
captureProgress.progressColor = defaultCaptureProgressColor
}
}

private fun FragmentLiveFeedbackBinding.renderProgressBar(validCapture: Boolean) {
captureProgress.progressColor = if (validCapture) validCaptureProgressColor else defaultCaptureProgressColor
captureProgress.value = vm.getNormalizedProgress()
}

private fun FragmentLiveFeedbackBinding.setManualCaptureButtonClickable(clickable: Boolean) {
if (!vm.isAutoCapture) {
captureFeedbackBtn.isClickable = clickable
Expand Down
Loading