Skip to content

[MS-1466] QR code scanning area is now bigger during the MFID workflow #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandr-simprints merged 1 commit into from
Jul 9, 2026
Merged

[MS-1466] QR code scanning area is now bigger during the MFID workflow #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 41 additions & 39 deletions ...ure/external-credential/src/main/res/layout-land/fragment_external_credential_scan_qr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,54 +22,56 @@
app:targetViewId="@+id/qrScannerArea"
tools:visibility="visible" />

<LinearLayout
<TextView
android:id="@+id/qrInstructionsText"
style="@style/Text.Headline5.White"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:gravity="center"
android:orientation="vertical"
app:layout_constraintBottom_toTopOf="@+id/buttonScan"
android:layout_margin="@dimen/padding_default"
app:layout_constraintBottom_toTopOf="@+id/qrScannerArea"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent">
tools:text="Place QR code in window" />

<TextView
android:id="@+id/qrInstructionsText"
style="@style/Text.Headline5.White"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_margin="@dimen/padding_default"
tools:text="Place QR code in window" />
<com.simprints.infra.view.imagecapture.CaptureTargetView
android:id="@+id/qrScannerArea"
android:layout_width="0dp"
android:layout_height="0dp"
app:cornerRadius="16dp"
app:layout_constraintBottom_toTopOf="@+id/buttonScan"
app:layout_constraintDimensionRatio="1:1"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintHeight_percent="0.5"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:shape="rect"
app:strokeColor="@color/simprints_blue"
app:strokeWidth="4dp" />

<com.simprints.infra.view.imagecapture.CaptureTargetView
android:id="@+id/qrScannerArea"
android:layout_width="200dp"
android:layout_height="200dp"
app:shape="rect"
app:strokeColor="@color/simprints_blue"
app:strokeWidth="4dp"
app:cornerRadius="16dp"/>
<com.google.android.material.card.MaterialCardView
android:id="@+id/qrPreviewCard"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginHorizontal="16dp"
android:layout_marginTop="16dp"
android:visibility="gone"
app:cardBackgroundColor="@color/simprints_blue"
app:cardUseCompatPadding="true"
app:layout_constraintBottom_toTopOf="@+id/buttonScan"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@+id/qrScannerArea"
tools:visibility="visible">

<com.google.android.material.card.MaterialCardView
android:id="@+id/qrPreviewCard"
<TextView
android:id="@+id/qrPreviewText"
style="@style/Text.Body1.White"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginHorizontal="16dp"
android:layout_marginTop="16dp"
android:visibility="gone"
app:cardBackgroundColor="@color/simprints_blue"
app:cardUseCompatPadding="true"
tools:visibility="visible">

<TextView
android:id="@+id/qrPreviewText"
android:gravity="center"
style="@style/Text.Body1.White"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_margin="8dp"
tools:text="QR_CODE" />
</com.google.android.material.card.MaterialCardView>
</LinearLayout>
android:layout_margin="8dp"
android:gravity="center"
tools:text="QR_CODE" />
</com.google.android.material.card.MaterialCardView>

<Button
android:id="@+id/buttonScan"
Expand Down
27 changes: 15 additions & 12 deletions ...rnal-credential/src/main/res/layout-sw600dp-land/fragment_external_credential_scan_qr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,29 @@

<TextView
android:id="@+id/qrInstructionsText"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintBottom_toTopOf="@+id/qrScannerArea"
tools:text="Place QR code in window"
style="@style/Text.Headline5.White"
android:layout_margin="@dimen/padding_default"
android:layout_width="wrap_content"
android:layout_height="wrap_content"/>
android:layout_height="wrap_content"
android:layout_margin="@dimen/padding_default"
app:layout_constraintBottom_toTopOf="@+id/qrScannerArea"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
tools:text="Place QR code in window" />

<com.simprints.infra.view.imagecapture.CaptureTargetView
android:id="@+id/qrScannerArea"
android:layout_width="200dp"
android:layout_height="200dp"
app:shape="rect"
app:strokeColor="@color/simprints_blue"
app:strokeWidth="4dp"
android:layout_width="0dp"
android:layout_height="0dp"
app:cornerRadius="16dp"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintDimensionRatio="1:1"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintHeight_percent="0.6"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
app:layout_constraintTop_toTopOf="parent"
app:shape="rect"
app:strokeColor="@color/simprints_blue"
app:strokeWidth="4dp" />

<com.google.android.material.card.MaterialCardView
android:id="@+id/qrPreviewCard"
Expand All @@ -55,6 +57,7 @@
android:visibility="gone"
app:cardBackgroundColor="@color/simprints_blue"
app:cardUseCompatPadding="true"
app:layout_constraintBottom_toTopOf="@+id/buttonScan"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@+id/qrScannerArea"
Expand Down
6 changes: 4 additions & 2 deletions feature/external-credential/src/main/res/layout/fragment_external_credential_scan_qr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,14 @@

<com.simprints.infra.view.imagecapture.CaptureTargetView
android:id="@+id/qrScannerArea"
android:layout_width="200dp"
android:layout_height="200dp"
android:layout_width="0dp"
android:layout_height="0dp"
app:shape="rect"
app:strokeColor="@color/simprints_blue"
app:strokeWidth="4dp"
app:cornerRadius="16dp"
app:layout_constraintWidth_percent="0.5"
app:layout_constraintDimensionRatio="1:1"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand Down