[CLOV-1675] part2: docs: update stale bpk-component-* paths to backpack-web/src layout - #4681
Conversation
…k-web/src/bpk-component-* Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Visit https://backpack.github.io/storybook-prs/4681 to see this build running in a browser. |
Vincent Liu (xiaogliu)
changed the title
Vincent Liu (xiaogliu)
changed the title
|
|
||
| ## List of packages | ||
|
|
||
| [`bpk-animate-height`](/packages/bpk-animate-height) |
There was a problem hiding this comment.
seems we do need to change this path as well
| [`bpk-component-table`](/packages/backpack-web/src/bpk-component-table) | ||
| [`bpk-component-text`](/packages/backpack-web/src/bpk-component-text) | ||
| [`bpk-component-textarea`](/packages/backpack-web/src/bpk-component-textarea) | ||
| [`bpk-theming`](/packages/bpk-theming) |
| [`bpk-react-utils`](/packages/bpk-react-utils) | ||
| [`bpk-mixins`](/packages/bpk-mixins) | ||
| [`bpk-stylesheets`](/packages/bpk-stylesheets) |
|
|
||
| ### Package Organization | ||
| ``` | ||
| packages/ |
There was a problem hiding this comment.
need to change this as well
| [`bpk-component-tooltip`](/packages/bpk-component-tooltip) | ||
| [`bpk-component-ticket`](/packages/backpack-web/src/bpk-component-ticket) | ||
| [`bpk-component-tooltip`](/packages/backpack-web/src/bpk-component-tooltip) | ||
| [`bpk-react-utils`](/packages/bpk-react-utils) |
|
|
||
| ## Anything else | ||
|
|
||
| The previous convention placed stories in `examples/bpk-component-{name}/`. Existing stories are being migrated in batches. When writing new stories, always use the colocated pattern. |
There was a problem hiding this comment.
seems we don't have this path either examples/bpk-component-{name}/
There was a problem hiding this comment.
seems we need to change the path here
| [`bpk-component-mobile-scroll-container`](/packages/backpack-web/src/bpk-component-mobile-scroll-container) | ||
| [`bpk-component-modal`](/packages/backpack-web/src/bpk-component-modal) | ||
| [`bpk-component-navigation-bar`](/packages/backpack-web/src/bpk-component-navigation-bar) | ||
| [`bpk-component-navigation-tab-group`](packages/backpack-web/src/bpk-component-navigation-tab-group) |
There was a problem hiding this comment.
keep consistency
| [`bpk-component-navigation-tab-group`](packages/backpack-web/src/bpk-component-navigation-tab-group) | |
| [`bpk-component-navigation-tab-group`](/packages/backpack-web/src/bpk-component-navigation-tab-group) |
|
|
||
| ### Design Token Architecture | ||
|
|
||
| Design tokens are centralized in `packages/bpk-mixins/_tokens.scss` which forwards all tokens from the foundations package: |
There was a problem hiding this comment.
should be packages/backpack-web/src/bpk-mixins/_tokens.scss
GC Zhu (gc-skyscanner)
left a comment
GC Zhu (gc-skyscanner)
left a comment
There was a problem hiding this comment.
Do we also need to remove the illustration added in https://github.com/Skyscanner/backpack/pull/4679/changes#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055R60 ? since we already changed the path in this PR
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1cae5b0 to
b7029ab
Compare
|
Visit https://backpack.github.io/storybook-prs/4681 to see this build running in a browser. |
Removed in #4681 |
Extends #4677 to fix additional stale paths missed by the original grep (which only caught
bpk-component-*).Additional files updated:
README.md,packages/backpack-web/README.md— non-component package links (bpk-animate-height,bpk-theming,bpk-react-utils,bpk-mixins,bpk-stylesheets)AGENTS.md,CONTRIBUTING.md,decisions/modern-sass-api.md—packages/bpk-mixinspaths.specify/templates/,.claude/— stalepackages/bpk-*andexamples/bpk-component-*/paths (the examples directory no longer exists; stories are colocated underpackages/backpack-web/src/bpk-component-*/src/)@skyscanner/backpack-web/bpk-component-*)