Add --env_vars flag to KFP runner for compile-time env injection#602
Draft
kmontemayor2-sc wants to merge 1 commit intomainfrom
Draft
Add --env_vars flag to KFP runner for compile-time env injection#602kmontemayor2-sc wants to merge 1 commit intomainfrom
kmontemayor2-sc wants to merge 1 commit intomainfrom
Conversation
Introduces a generic, repeatable --env_vars KEY=VALUE flag on gigl.orchestration.kubeflow.runner that bakes environment variables into every GiGL-owned container at compile time via PipelineTask.set_env_variable. Applied uniformly across all SPECED_COMPONENTS plus the GLT eligibility check and log_metrics_to_ui tasks; the managed VertexNotificationEmailOp exit handler is intentionally excluded. Rejected with --action=run_no_compile to prevent silent UX failure (envs are baked at compile time, so the flag would do nothing in that mode). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 17:22:22UTC : 🔄 @ 18:45:18UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:22:22UTC : 🔄 @ 18:22:52UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:22:27UTC : 🔄 @ 17:23:34UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:22:28UTC : 🔄 @ 17:31:15UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:22:30UTC : 🔄 @ 18:46:57UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:22:32UTC : 🔄 @ 17:32:28UTC : ✅ Workflow completed successfully. |
yliu2-sc
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a generic, repeatable --env_vars KEY=VALUE flag on gigl.orchestration.kubeflow.runner that bakes environment variables into every GiGL-owned container at compile time via PipelineTask.set_env_variable. Applied uniformly across all SPECED_COMPONENTS plus the GLT eligibility check and log_metrics_to_ui tasks; the managed VertexNotificationEmailOp exit handler is intentionally excluded.
Rejected with --action=run_no_compile to prevent silent UX failure (envs are baked at compile time, so the flag would do nothing in that mode).
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO