fix: Exclude raft layers from slow-down layer count#526
Open
zackaree-shen wants to merge 1 commit into
Open
Conversation
- Subtract raft_layers() from layer_id() so slow-down counting starts from the first model layer - Change _layer > 0 to _layer >= 0 so the first model layer over raft also gets proper initial speed - Ensures the model's actual first few layers receive the full slow_down_layers gradient
1299d57 to
6b6397a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where slow-down layers (
slow_down_layers) incorrectly counted raft layers, causing the model's actual first few layers to receive insufficient speed reduction.Root Cause
In
GCode::_extrude(), the slow-down layer lerp used rawlayer_id()which includes raft layers in its counting. With 3 raft layers andslow_down_layers=5, the 3 raft layers consumed 3 slow-down slots, leaving only 2 for the actual model layers.Fix
raft_layers()fromlayer_id()so slow-down counting starts from the first model layer_layer > 0to_layer >= 0so the first model layer over raft also receives proper initial speedChanges
src/libslic3r/GCode.cppBehavior (example: 3 raft layers + slow_down_layers=5)
Verification