(fix): Cherry-picking mainline Klipper AHT10 commits and adding method to temperature_combined#6
Open
jimmyjon711 wants to merge 4 commits into
Open
(fix): Cherry-picking mainline Klipper AHT10 commits and adding method to temperature_combined#6jimmyjon711 wants to merge 4 commits into
jimmyjon711 wants to merge 4 commits into
Conversation
Signed-off-by: Lev Voronov <minicx@disroot.org>
Split into three classes with proper init commands: - AHT1x: 0xE1 (AHT10, AHT15) - AHT2x: 0xBE (AHT20, AHT21, AHT25) - AHT3x: auto-cal (AHT30) Signed-off-by: Lev Voronov <minicx@disroot.org>
Signed-off-by: Lev Voronov <minicx@disroot.org>
- Adding place holder method so that temperature_combined can be used without klipper erroring out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked the following commits so that users can properly use AHT10 class for AHT20/AHT30 temperature sensors:
Screenshot of this working, lane1/lane2 in picture below uses AHT2X sensors:
Added
set_read_tolerancemethod to temperature_combined.py so that users can combine multiple temperature sensors, without this change klipper errors out since heaters.py tries to update read tolerance and this method does not exist for this call. This is ok to add since temperature_combined does not communicate with MCUs, but instead combines temperature values from multiple temperature sensors.Screenshot below is from my ViViD connected to my U1 🙂, as it uses temperature combined with AHT3X sensors: