chore: disable vitest interopDefault, remove dotenvx#1207
Merged
John-David Dalton (jdalton) merged 4 commits intomainfrom Apr 16, 2026
Merged
chore: disable vitest interopDefault, remove dotenvx#1207John-David Dalton (jdalton) merged 4 commits intomainfrom
John-David Dalton (jdalton) merged 4 commits intomainfrom
Conversation
Set deps.interopDefault: false in all vitest configs for native CJS resolution matching Node runtime behavior. Remove dotenvx from pre-commit hook, workspace catalog, and devDependencies. Inline SOCKET_CLI_NO_API_TOKEN=1 directly.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ffe3325. Configure here.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
Resolved issue |
John-David Dalton (jdalton)
deleted the
chore/vitest-interop-remove-dotenvx
branch
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deps.interopDefault: falsein all 6 vitest configs so vitest matches Node's native ESM-CJS interop behavior (no auto-unwrapping of.default)@dotenvx/dotenvxfrom devDependencies and workspace catalog — only used in pre-commit hookSOCKET_CLI_NO_API_TOKEN=1directly instead of loading via dotenvxTest plan
pnpm testpasses withinteropDefault: falseNote
Medium Risk
Changing Vitest interop behavior can surface import/require mismatches and break tests that relied on default-export unwrapping. Tooling cleanups are low risk but may affect local pre-commit behavior.
Overview
Sets
deps.interopDefault: falseacross all Vitest configs (base, isolated, root, and CLI unit/integration/e2e) so tests use Node-like ESM/CJS import semantics (no automatic.defaultunwrapping).Removes
@dotenvx/dotenvxfrom the workspace (including lockfile/catalog) and simplifies the Huskypre-commithook to run staged tests withSOCKET_CLI_NO_API_TOKEN=1directly. Also deletes the disabled.github/dependabot.ymlfile.Reviewed by Cursor Bugbot for commit ffe3325. Configure here.