feat(phase-54): Integration Truth — wire orchestrator and close silent no-ops - #32
Merged
Merged
Conversation
RouteQuery now runs MemoryOrchestrator (expand → fan-out → rank fusion → rerank) so CLI and gRPC callers share the same pipeline. LLM rerank uses a Completer wrapping ApiSummarizer; CrossEncoder hard-errors. CLI --rerank is forwarded. cargo tree -i memory-orchestrator lists memory-service. BM25 outbox IndexEvent/UpdateToc index event bodies (DocType::Event) with warn + BM25_SKIPPED_NOOP on skip — no silent success. Hybrid fuses BM25 and vector via the one canonical fuse_weighted in fusion.rs. --background exits non-zero. recover_lock replaces production lock unwraps. Daemon start attaches BM25/vector/topics/completer indexes.
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
CI clippy on rustc 1.98 denies clippy::manual_slice_fill. Pre-existing in memory-types; unblocks Phase 54 PR CI.
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
temporarily deployed
to
e2e-cli
August 30, 2026 16:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
RichardHightower
added a commit
that referenced
this pull request
Aug 30, 2026
Docs-only spec for Phases 54-58. Implementation of Phase 54 is #32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements v3.1 Phase 54 (Integration Truth) from the Make It True spec (docs PR #31). No new capabilities — every public claim this phase covers is now executable.
Independent of #31 (docs-only). Do not confuse with the old unused
gsd/phase-54-daily-markdown-exportbranch.What this makes true
RouteQuerymemory-servicedepends onmemory-orchestrator;RouteQuerycallsMemoryOrchestrator::query_ranked. CLI--rerankis forwarded. Real LLM reranker viaCompleterwrappingApiSummarizer.CrossEncoderRerankerhard-errors (NotImplemented).IndexEvent/UpdateTocindex the event body (DocType::Event). Missing eventswarn!+BM25_SKIPPED_NOOP— never silentOkwhile doing nothing.Hybridlayer is hybridCrateLayer::Hybridfetches BM25 + vector and fuses with equal weights.fuse/fuse_weightedincrates/memory-orchestrator/src/fusion.rs. HybridSearch RPC calls it.rg -l 'reciprocal|rrf' crates/→fusion.rsonly.memory-daemon start --backgroundexits non-zero with guidance. Default start is foreground. Indexes (BM25/vector/topics/completer) are attached viaQueryIndexBundle.recover_lockinmemory-types(metricLOCK_POISON_RECOVERIES). Production sites in vector/hnsw/registry/usage recover instead of panicking.Execution evidence
cargo tree -i memory-orchestrator→memory-service→memory-daemon,memory-cli,e2e-teststest_route_query_names_fusion_stage,test_llm_rerank_reorders_bm25_hits,test_hybrid_fusion_differs_from_either_input,test_process_index_event_makes_event_findable,recover_lock_recovers_from_poisontest_full_pipeline_ingest_toc_grip_route_queryassertsexplanation.fusion_stage == "rank_fusion"cargo fmt --all -- --checkgreencargo clippy --workspace --all-targets --all-features -- -D warningsgreencargo test --workspace --all-features --lib --binsgreen (0 failures)RUSTDOCFLAGS=-D warnings cargo doc --no-deps --workspace --all-featuresgreenProto
RouteQueryRequestgainsrerank_mode/expand_query.ExplainabilityPayloadgainsfusion_stage/rerank_mode.TeleportDocType::Event = 3.Not in this PR
Phases 55–58 (performance truth, honest benchmarks, shop window, launch) stay sequential after this.