Skip to content

Better error handling#25

Merged
Kade-N merged 9 commits intomainfrom
better-error-handling
May 8, 2026
Merged

Better error handling#25
Kade-N merged 9 commits intomainfrom
better-error-handling

Conversation

@Kade-N
Copy link
Copy Markdown
Member

@Kade-N Kade-N commented Apr 25, 2026

  • Clean up various areas of code, less spaghetti
  • Mod Identity
    • Relocated dllsBuild handling to Easy Installer (it's not relevant anywhere else)
    • Reject installing mods where dllsBuild is present but cannot be parsed as a version, with a clear error message
    • When installing a mod that requires newer DLLs version, show current and required DLLs version, and force an update check on next launch
  • Spore Path handling (closes Change Galactic Adventures Not Found message #13)
    • Overhaul how LK locates the game's folders
      • New behavior attempts to mimic how the game itself does it, by only checking for DataDir
      • Idea is that if the game can run, then LK should work, and contrapositively, if the game cannot run, LK should not work
    • Removed PathDialog, users can no longer choose the game folder
      • Users often chose the wrong one, leading to problems
      • Should be obsolete - if the folder can't be detected, then the game likely won't work on its own
      • Also removed LauncherSettings as this was the only thing there
    • Add new error for when game has been downloaded from Steam, but Steam still needs to run its installation script
    • Add new error for when game has been installed from Steam, but wrong game was launched from Steam (closes Mod packages may be installed to wrong DataDir on Steam #26)
    • Clean up code relating to registry paths, add support for C&C path on GOG/Steam (unused, but may be useful in the future if we implement C&C Fixer #21)
  • Centralize and update how errors and support info is displayed
    • Added SupportInfo which standardizes how this info (game version, LK version, paths...) is obtained and displayed
    • Replace path.info with support,info, shows more info
    • Most error messages now use this system
    • Updated phrasing in many messages for consistency and clarity
    • Added checks for LAA/4GB patch, if enabled then this is displayed with game version
    • Added new warning when LAA/4GB patch is used on an incompatible game version (currently just Steam October2024 due to steamstub DRM)
    • Easy Uninstaller now shows game version info
  • When updates are blocked, warn user and prompt them to re-enable updates in the following cases:
    • The first time LK is launched (if updates are blocked before first launch)
    • Every 30 days
    • After a failed attempt to install a mod that requires newer LK or ModAPI DLLs version

Kade-N added 3 commits April 11, 2026 19:22
cleaned up, added new error for when dllsBuild is present but invalid
Streamlined and centralized logic for finding game folder paths, updated logic to more closely match the game, removed path dialog as it should be obsolete, updated related strings
Moved most errors to a common system that shows support info, add check for LAA and show error if used on incompatible game version
Comment thread ModAPI.Common/SporePath.cs Fixed
Comment thread ModAPI.Common/SporePath.cs Fixed
Comment thread ModAPI.Common/SupportInfo.cs Dismissed
Comment thread ModAPI.Common/SupportInfo.cs Dismissed
Comment thread ModAPI.Common/SupportInfo.cs Fixed
Comment thread ModAPI.Common/Update/UpdateManager.cs Dismissed
Comment thread ModAPI.Common/SupportInfo.cs Dismissed
Comment thread ModAPI.Common/SupportInfo.cs Dismissed
Copy link
Copy Markdown
Member

@Rosalie241 Rosalie241 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code wise it all seems fine, I've also tested it briefly and it still works fine on my end.

If users have issues then those can be quickly fixed anyway so I'm not too worried about merging it as-is.

@Rosalie241 Rosalie241 force-pushed the better-error-handling branch from 36399ee to 6a2e2a5 Compare May 7, 2026 23:35
Comment thread ModAPI.Common/SporePath.cs Dismissed
Comment thread ModAPI.Common/SporePath.cs Dismissed
@Kade-N Kade-N merged commit 3a5115e into main May 8, 2026
8 checks passed
@Kade-N Kade-N deleted the better-error-handling branch May 8, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Mod packages may be installed to wrong DataDir on Steam Change Galactic Adventures Not Found message

2 participants