chore: correct the documented rumdl invocation and fix its one finding - #185
Merged
Merged
Conversation
CLAUDE.md told contributors to run `rumdl .`, which is not a valid invocation — it exits with "For more information, try '--help'" without linting anything. CI has always run `rumdl check .`, so anyone following the documented workflow got a silent non-run and CI was the first thing to actually lint their markdown. - Align CLAUDE.md with the CI workflow: `rumdl check .` - Fix the one issue that surfaced once the linter actually ran: MD077 over-indented continuation in the Copilot session end command. The line continues a `-` bullet (2-space continuation), not the numbered item above it (3-space), which is why only this one flagged `rumdl check .` now reports 89 files clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EddJxaTMXyj7o4ndrqfCxa
There was a problem hiding this comment.
🟡 Changes recommended
The session plugin was modified but its version was not bumped in the plugin manifests, so consumers may not receive the update.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR fixes contributor documentation so the markdown linter is invoked correctly (rumdl check .) and adjusts one Copilot command markdown file to satisfy the markdown linter once it actually runs.
Changes:
- Update
CLAUDE.mdto document the correctrumdlinvocation used by CI (rumdl check .). - Fix a single markdownlint (MD077) indentation finding in
plugins-copilot/session/commands/end.md.
File summaries
| File | Description |
|---|---|
CLAUDE.md |
Corrects the documented markdown lint command to match CI (rumdl check .). |
plugins-copilot/session/commands/end.md |
Adjusts indentation to resolve the MD077 markdownlint finding. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - otherwise use the equivalent host-native PR listing command if available | ||
|
|
||
| If found, extract the PR URL and number, skip steps 3-7, and jump directly to step 8 (CI watch) using the existing PR info. | ||
| If found, extract the PR URL and number, skip steps 3-7, and jump directly to step 8 (CI watch) using the existing PR info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdtold contributors to runrumdl .as the markdown lint step. That is not a valid invocation — it exits withFor more information, try '--help'without linting anything. CI has always runrumdl check ., so anyone following the documented workflow got a silent non-run, and CI was the first thing to actually lint their markdown.Caught while doing a final validation sweep, after running the scoped form (
rumdl check <path>) all session without noticing the top-level command in the docs was different.Changes
Align
CLAUDE.mdwith.github/workflows/ci.yml:rumdl check .Fix the one issue that surfaced once the linter actually ran:
That line continues a
-bullet, which takes a 2-space continuation — not the numbered item above it, which takes 3. That is why it was the only one of the two adjacent continuations to flag.Pre-existing, last touched by
c35a2c7; unrelated to the recent git-tools and meal-planning work.Test plan
rumdl check .— 89 files, 0 issues (previously 1 issue, and not run at all if you followed CLAUDE.md)validate-plugins.sh302/0validate-frontmatter.sh103/0utils/sync.sh --check— no drift