fix(meal-planning): follow the staples doc's three-list restructure in add-recipe - #188
Merged
Merged
Conversation
…n add-recipe The staples document was restructured from a single do-not-stock list into three lists that do different jobs: a ban list that changes a recipe, pantry staples that decide a shopping line's class, and preferred substitutes that are offerable defaults. add-recipe was still reading it as one list and applying it as one instruction, which is what caused recipes to have ingredients wrongly deleted -- pantry-staple status was being treated as a reason to drop an ingredient instead of just a shopping classification. - Step 2 now distinguishes the three lists and states the rule that an ingredient absent from all of them is simply bought, never omitted - the preflight role-search fallback names the three lists instead of the old "pantry staples and do-not-stock" - retrofit mode gained a check for the inverse error: an ingredient removed from a recipe for not being a pantry staple, which is never valid -- a real instance was found and fixed in the KB during this work Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168tytbpHtdv621gFmipKbZ
There was a problem hiding this comment.
🟢 Approval recommended
The updates are internally consistent, remove outdated staples-doc references, and correctly separate “ban list” vs “pantry staples” behavior to address the described silent deletion bug.
Pull request overview
Updates the meal-planning plugin’s add-recipe skill instructions to match the KB staples document’s new three-list structure, preventing pantry-staple guidance from being misapplied as an ingredient-removal rule during recipe authoring and retrofits.
Changes:
- Updates the preflight fallback role-search wording to reference the three staples lists (pantry staples, ban list, preferred substitutes).
- Rewrites Step 2 (“Conform it to the profile”) to explicitly distinguish what each staples list does, including the rule that unlisted ingredients are bought (not omitted).
- Extends retrofit guidance to detect and correct the “ingredient removed for not being a pantry staple” error case.
File summaries
| File | Description |
|---|---|
| plugins-claude/meal-planning/skills/add-recipe/SKILL.md | Aligns add-recipe instructions with the staples doc restructure to prevent incorrect ingredient deletion and improve retrofit checks. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The meal-planning KB and this plugin encode the same rules in two places, and
the KB half already changed. The staples document used to carry a single "do
not stock" section; it was restructured into three lists that do different
jobs (a ban list that changes a recipe, pantry staples that decide a shopping
line's class, and preferred substitutes that are offerable defaults). This
skill's
add-recipewas still reading it the old way, pointing at a sectionthat no longer exists.
Nothing about that failure is loud. Nothing errors when a skill's fallback
role-search or its "apply this section" instruction points at a name the KB
no longer has — it just resolves to less than intended, or gets collapsed
into a single instruction where pantry-staple status quietly becomes a
reason to drop an ingredient. That's the actual bug this closes: recipes
were having ingredients wrongly deleted because "pantry staples" and "do not
stock" got applied as one thing.
What changed
lists explicitly, and states the rule that an ingredient absent from all
three is simply bought — never omitted, never avoided.
of the old "pantry staples and do-not-stock".
removed from a recipe for not being a pantry staple. That's never a
valid reason to drop something. A real instance of this was found and
fixed in the KB while doing this work.
Test plan
.github/scripts/validate-plugins.sh— 301 checks, 0 failures.github/scripts/validate-frontmatter.sh— 103 checks, 0 failuresrumdl checkon the changed file — no issuestests/test.sh— full suite run, see CI/comment for result