refactor: optimise exceptions thrown; feat: implement MatchResult; fix: compass accuracy#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves developer experience (DX) across the board.
Ocrthrows aRuntimeException/UncheckedIOExeption-> to fail fast -> if the project files aren't valid then the project shouldn't run.VirtualMouseUtils.moveTo()'sInterruptedExceptionwas a remnant from a previous version, my fault, safely removed.TemplateMatching.match()no longer throwsExceptionand does not automatically log failure.DaxException: for a generalised, unaccounted for error, and the parent of the next two.DaxAuthException: if the service is down/the API key is invalid.DaxRateLimitException: for when the service hits its maximum load, meaning the user has to wait.TemplateMatching.match()has been reworked and optimised for the user in mind.MatchResultobject which includes:Rectangle bounds: the zone local location and size of the template image found within the base.double score: The minVal/threshold/confidence at which the image correlated to the base (lower = better).boolean success: Whether the template was successfully found within the base image.String message: In case there is no match, this will contain further information.MatchResultobject so it provides a lot of granularity rather than a catch allException, utilising thesuccess()boolean has been very useful whilst testing.Walkerhas been refactored:CVTemplates.bathas been changed to reflect this.ItemDropperchanges:BaseScriptrather than theController, for consistency across utilities.int[] excludearray.