refactor: cross-platform and build improvements#64
Merged
Conversation
TechnologicalDifferences
commented
Apr 14, 2026
TechnologicalDifferences
commented
Contributor
- LinuxProcessManager: implement getPid() via /proc/[pid]/cmdline scanning; remove X11/JNA window operations, fields, constructor, close(), and AutoCloseable — class now implements ProcessManager only
- ProcessManagerFactory: add explicit Linux guard and throw UnsupportedOperationException for unrecognised OSes instead of silently falling through to Linux
- ProfileManager: replace hard-coded ~/.runelite/profiles2 path with OS-aware resolveProfileDir() that handles Windows AppData, Linux Bolt Flatpak, macOS Library/Application Support, and standard Linux
- settings.gradle.kts: canonicalise project dir to fix Spotless on systems where /home is a symlink (e.g. Fedora /var/home)
- ScriptInstance: clear thread interrupted flag before broadcast() so the WebSocket semaphore acquire succeeds after stop() interrupts the script thread
- CVTemplates.sh: add setup script to fetch SRL fonts, OSBC UI templates, and mouse-click images and generate font index files
- gradlew: mark as executable
- LinuxProcessManager: implement getPid() via /proc/[pid]/cmdline scanning; remove X11/JNA window operations, fields, constructor, close(), and AutoCloseable — class now implements ProcessManager only - ProcessManagerFactory: add explicit Linux guard and throw UnsupportedOperationException for unrecognised OSes instead of silently falling through to Linux - ProfileManager: replace hard-coded ~/.runelite/profiles2 path with OS-aware resolveProfileDir() that handles Windows AppData, Linux Bolt Flatpak, macOS Library/Application Support, and standard Linux - settings.gradle.kts: canonicalise project dir to fix Spotless on systems where /home is a symlink (e.g. Fedora /var/home) - ScriptInstance: clear thread interrupted flag before broadcast() so the WebSocket semaphore acquire succeeds after stop() interrupts the script thread - CVTemplates.sh: add setup script to fetch SRL fonts, OSBC UI templates, and mouse-click images and generate font index files - gradlew: mark as executable
StaticSweep
requested changes
Apr 14, 2026
StaticSweep
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.