Skip to content

Deprecated the old HomeAssistantPlugin and added a new one#137

Merged
Core447 merged 2 commits into
StreamController:mainfrom
gensyn:main
Nov 26, 2025
Merged

Deprecated the old HomeAssistantPlugin and added a new one#137
Core447 merged 2 commits into
StreamController:mainfrom
gensyn:main

Conversation

@gensyn

@gensyn gensyn commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Checks

@Core447

Core447 commented Nov 22, 2025

Copy link
Copy Markdown
Member

Nice work!

Do you need the requirements.txt file? All the included packages already come with StreamController.

@gensyn

gensyn commented Nov 22, 2025

Copy link
Copy Markdown
Contributor Author

Huh, I guess not then. Will remove it soon.

@gensyn

gensyn commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

It turns out I do need the file because I use it to install the dependencies for my unit tests. These run without the StreamController framework so I cannot use your packages.

@Core447

Core447 commented Nov 26, 2025

Copy link
Copy Markdown
Member

Do your unit tests still work when you rename the file to something else? e.g. requirements_unittests.txt or something? Because then StreamController ignores the file.

@gensyn

gensyn commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

Oh yeah, I can name it whatever I want. I just need to have the Github Workflow reflect the change. I'll update the PR.

@gensyn

gensyn commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

Done.

@Core447

Core447 commented Nov 26, 2025

Copy link
Copy Markdown
Member

Perfect. Thank you!

@Core447 Core447 merged commit e038aa3 into StreamController:main Nov 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants