Support multiple simulations per tool#79
Open
m-sanders wants to merge 1 commit into
Open
Conversation
mergeSimulationFixtures keyed by tool name, so a second JSON fixture targeting the same tool overwrote the first. Group by tool, drop the auto-discovered slot when no fixture file reuses its name, and key each fixture entry by its filename instead. Dedup UI tool registrations in the dev MCP server so duplicate simulations no longer crash startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs already advertise multiple
.jsonfixtures targeting the same tool (e.g.show-albums.json+show-albums-empty.json), but in practice only the last one survived:mergeSimulationFixtureslooked sims up bytoolname and overwrote, and the dev MCP server registered the same UI tool twice and only showed the last registry.mergeSimulationFixtures: group fixtures by tool. When a tool has multiple fixtures, drop the auto-discovered slot (unless one fixture's filename matches the tool) and key each entry by its filename. Single-fixture flow is unchanged.createAppServer: skip duplicate UI tool registrations the same way plain tools already do. First simulation'stoolResultis used for the fallback mock.mergeSimulationFixturesis now exported so tests call the real function instead of inlining the logic.