feat(sqlserver): add Encrypt dropdown to connection dialog#236
Open
saurabh500 wants to merge 2 commits into
Open
feat(sqlserver): add Encrypt dropdown to connection dialog#236saurabh500 wants to merge 2 commits into
saurabh500 wants to merge 2 commits into
Conversation
Adds an Encrypt selector (Yes/No/Strict) to the New Connection modal when driver is SQL Server. Frontend-only wiring; backend already supports the encrypt field on ConnectionParams. Note (draft): the new field still needs to be threaded through connection save/load (Config mapping) before this can ship. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Change encrypt default from empty string to undefined; backend already defaults to EncryptionLevel::On when None, matching 'yes' behavior - Normalize empty encrypt string on save to avoid stale '' values from old connections - Add encrypt, trust_server_certificate, auth_mode to canonical ConnectionParams in connections.ts and credentials.ts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by kimi-k2.6 · 259,128 tokens |
Contributor
Author
|
This still needs work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an Encrypt dropdown to the New Connection modal when the driver is SQL Server. Three options: Yes (default), No, Strict.
The backend already accepts the
encryptfield onConnectionParamsand maps it correctly inpool.rs::build_config(strict→Required,no→NotSupported, default →On). This PR only adds the missing UI control.Changes
src/components/modals/NewConnectionModal.tsx— local interface field, formData seed, driver-change reset, and conditional<Select>rendered fordriver === "sqlserver"between the host/port grid and credentials block.src/i18n/locales/en.json—newConnection.encryptlabel +encryptModes.{yes,no,strict}option labels (mirroring the existingsslModespattern).Why draft
The new
encryptvalue is not yet threaded into the connection save/load path (i.e., theConfigmapping where saved connections are reloaded into the dialog). Marking draft until that round-trip is wired so a saved connection re-opens with the previously chosen Encrypt setting.Manual test
encryptis reset.build_configtest coverage already validates the mapping).Out of scope
trust_server_certificateUI control (field exists on the interface, no surface yet).defaultValue.